From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Wed, 9 Jul 2008 21:15:35 +0200
Subject: [U-Boot-Users] [PATCH] usb: add support for R8A66597
	usb	controller
In-Reply-To: <4874AA0A.6090700@renesas.com>
References: <4874AA0A.6090700@renesas.com>
Message-ID: <20080709191535.GD18713@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

 +
> +#include <common.h>
> +#include <usb.h>
> +#include <asm/io.h>
> +
> +#include "r8a66597.h"
> +
> +#if defined(CONFIG_USB_R8A66597_HCD)
please move to the Makefile
> +
> +#ifdef R8A66597_DEBUG
> +#define R8A66597_DPRINT		printf
> +#else
> +#define R8A66597_DPRINT(...)
> +#endif
why not using debug()
> +
> +static const char hcd_name[] = "r8a66597_hcd";
> +static unsigned short clock = CONFIG_R8A66597_XTAL;
> +static unsigned short vif = CONFIG_R8A66597_LDRV;
> +static unsigned short endian = CONFIG_R8A66597_ENDIAN;
> +static struct r8a66597 gr8a66597;
is it not possible to have a better name for the struct and the var
and btw for the function naming?
> +
> +static void set_devadd_reg(struct r8a66597 *r8a66597, u8 r8a66597_address,
> +			   u16 usbspd, u8 upphub, u8 hubport, int port)
> +{
> +	u16 val;
> +	unsigned long devadd_reg = get_devadd_addr(r8a66597_address);
> +
> +	val = (upphub << 11) | (hubport << 8) | (usbspd << 6) | (port & 0x0001);
> +	r8a66597_write(r8a66597, val, devadd_reg);
> +}
> +
Best Regards,
J.