[U-Boot-Users] [PATCH] Adds support for Xilinx Uart Lite on ppc4xx

[Wolfgang Denk <wd@denx.de>]

In message <aa76a2be0807101152w4993ef3ckddec30baf25f72a1@mail.gmail.com> you wrote:
> 
>     This files already exist on the u-boot tree. They are located in
> include/asm-microblaze and include/asm-microblaze/arch-microblaze .
> They give support to a simple uart which can also be used on the
> powerpc, I have just copied them from one directory to another.

That's even worse. Don't do that. NEVER duplicate code.

Software engineering is an art of NOT duplicating previous work or
code.

>     This files have been provided by Xilinx, and they are the same in
> all the OS and boot loaders, I don't  think they break any GPL
> license,

IANAL. Are you a laywer?

> >> +*     This program is free software; you can redistribute it and/or modify it
> >> +*     under the terms of the GNU General Public License as published by the
> >> +*     Free Software Foundation; either version 2 of the License, or (at your
> >> +*     option) any later version.
> > ..
> >> +*     XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
> >> +*     COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
> >> +*     ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
> >> +*     XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
> >> +*     FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
> >> +*     ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
> >
> > This is IMHO in contradiction to the GPL clause above.

If the code is under GPL there should not be any undefined (probably
dangerous?) third party rights. If this should be the case, the file
cannot be released under GPL.

> >> +*     Xilinx hardware products are not intended for use in life support
> >> +*     appliances, devices, or systems. Use in such applications is
> >> +*     expressly prohibited.
> >
> > This restriction is IMHO in contradiction to the GPL clause above.


[BTW: please do not top-post / full-quote.]


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you hear an onion ring, answer it.