public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] USB: shutdown USB before booting
Date: Thu, 10 Jul 2008 21:50:43 +0200	[thread overview]
Message-ID: <20080710195043.8DBE6242FF@gemini.denx.de> (raw)
In-Reply-To: Your message of "Thu, 10 Jul 2008 15:02:14 +0200." <200807101502.14543.sr@denx.de>

In message <200807101502.14543.sr@denx.de> you wrote:
> 
> Yes, I remember hearing of this problem. I thought it was already fixed. Seems 
> not to be the case. Please find a comment below.

I thought so, too. But Martin Krause's patch somehow got stuck in the
gearbox.

> By implementing this usb_stop() in do_bootm() you prevent this problem in many 
> cases (e.g. Linux booting). But unfortunately not in all cases. For 
> example "bootelf" or "bootvx" are not fixed.

You are right.

> Can't this be solved in a different way. By calling usb_stop each time after 
> an USB command completes. IIRC, this is how it is done in the U-Boot network 
> implementation too.
> 
> What do you think?

I pulled in the current patch so we reduce  the  problem  as  far  as
possible; any better implementation is welcome.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning there was nothing.
And the Lord said "Let There Be Light!"
And still there was nothing, but at least now you could see it.

  reply	other threads:[~2008-07-10 19:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 12:47 [U-Boot-Users] [PATCH] USB: shutdown USB before booting Markus Klotzbücher
2008-07-10 13:02 ` Stefan Roese
2008-07-10 19:50   ` Wolfgang Denk [this message]
2008-07-10 19:48 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080710195043.8DBE6242FF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox