public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Round the serial port clock divisor value returned by	calc_divisor()
Date: Thu, 10 Jul 2008 21:25:40 -0400	[thread overview]
Message-ID: <20080711012540.GA29444@cideas.com> (raw)

This formula is better at avoiding integer overflow.

Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
---

(try 2)

The formula I proposed previously in this thread compiles OK.  I cannot
verify it is correct on real hardware, however.
<http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/43499/focus=43506>

Best regards,
gvb 

 drivers/serial/serial.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c
index 182ca2d..48579ae 100644
--- a/drivers/serial/serial.c
+++ b/drivers/serial/serial.c
@@ -150,7 +150,9 @@ static int calc_divisor (NS16550_t port)
 	 * but we need to round that value by adding 0.5 or 8/16.
 	 * Rounding is especially important at high baud rates.
 	 */
-	return (((16 * CFG_NS16550_CLK) / MODE_X_DIV / gd->baudrate) + 8) / 16;
+	return (CFG_NS16550_CLK + (gd->baudrate / 2)) /
+		(MODE_X_DIV * gd->baudrate);
+
 }
 
 #if !defined(CONFIG_SERIAL_MULTI)
-- 
1.5.6

             reply	other threads:[~2008-07-11  1:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11  1:25 Jerry Van Baren [this message]
2008-07-11 13:49 ` [U-Boot-Users] [PATCH] Round the serial port clock divisor valuereturned by calc_divisor() Hugo Villeneuve
2008-07-11 15:13   ` Jerry Van Baren
  -- strict thread matches above, loose matches on Subject: below --
2008-07-08 17:32 [U-Boot-Users] [PATCH] Round the serial port clock divisor value returned " Hugo Villeneuve
2008-07-08 17:50 ` Jerry Van Baren
2008-07-08 18:21   ` Hugo Villeneuve
2008-07-08 18:35     ` Jerry Van Baren
2008-07-08 18:54       ` Hugo Villeneuve
2008-07-15 15:23 ` Hugo Villeneuve
2008-07-15 15:53   ` Jerry Van Baren
2008-07-15 19:54     ` Wolfgang Denk
2008-07-15 19:53   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711012540.GA29444@cideas.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox