From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 11 Jul 2008 11:36:24 +0200 Subject: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support In-Reply-To: <4618.7248-495-1777888767-1215766461@seznam.cz> References: <4618.7248-495-1777888767-1215766461@seznam.cz> Message-ID: <200807111136.24462.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 11 July 2008, Michal Simek wrote: > Still is there coding style issue. > > and you have one extra header file which is uneeded. I recommend you > move usefull values directly to driver. > > WD: I looked at include/dtt.h there are many driver specific values. IMHO > these value should be usefull move to driver c file. What do you think > about? Full ACK. Patches welcome. :) Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================