From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 11 Jul 2008 12:58:30 +0200
Subject: [U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support
In-Reply-To: <1215771320-23805-2-git-send-email-ricardo.ribalda@uam.es>
References: <1215771320-23805-1-git-send-email-ricardo.ribalda@uam.es>
	<1215771320-23805-2-git-send-email-ricardo.ribalda@uam.es>
Message-ID: <200807111258.31054.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday 11 July 2008, Ricardo Ribalda Delgado wrote:
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>

Ricardo, please address my (nitpicking) comments below in the next version. 
You could also run "Lindent" if you don't want to do this coding style 
cleanup manually.

> ---
>  drivers/hwmon/Makefile  |    1 +
>  drivers/hwmon/adt7460.c |   85
> +++++++++++++++++++++++++++++++++++++++++++++++ include/dtt.h           |  
>  3 +-
>  3 files changed, 88 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/hwmon/adt7460.c
>
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index 065433a..e301eaa 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -37,6 +37,7 @@ COBJS-y += ds1775.o
>  COBJS-$(CONFIG_DTT_LM73) += lm73.o
>  COBJS-y += lm75.o
>  COBJS-y += lm81.o
> +COBJS-$(CONFIG_DTT_ADT7460) += adt7460.o
>
>  COBJS	:= $(COBJS-y)
>  SRCS	:= $(COBJS:.o=.c)
> diff --git a/drivers/hwmon/adt7460.c b/drivers/hwmon/adt7460.c
> new file mode 100644
> index 0000000..28b2eb7
> --- /dev/null
> +++ b/drivers/hwmon/adt7460.c
> @@ -0,0 +1,85 @@
> +/*
> +    (C) Copyright 2008
> +    Ricado Ribalda-Universidad Autonoma de Madrid, ricardo.ribalda at uam.es
> +    This work has been supported by: Q-Technology  http://qtec.com/
> +
> +    This program is free software: you can redistribute it and/or modify
> +    it under the terms of the GNU General Public License as published by
> +    the Free Software Foundation, either version 2 of the License, or
> +    (at your option) any later version.
> +
> +    This program is distributed in the hope that it will be useful,
> +    but WITHOUT ANY WARRANTY; without even the implied warranty of
> +    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +    GNU General Public License for more details.
> +
> +    You should have received a copy of the GNU General Public License
> +    along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +*/
> +
> +#include <common.h>
> +#include <i2c.h>
> +#include <dtt.h>
> +
> +#define ADT7460_ADDRESS 	0x2c
> +#define ADT7460_INVALID 	128
> +#define ADT7460_CONFIG		0x40
> +#define ADT7460_REM1_TEMP	0x25
> +#define ADT7460_LOCAL_TEMP	0x26
> +#define ADT7460_REM2_TEMP	0x27
> +
> +int dtt_read(int sensor, int reg)
> +{
> +	u8 dir=reg;

Spaces missing:

	u8 dir = reg;

> +	u8 data;
> +
> +	if ( i2c_read(ADT7460_ADDRESS,dir,1,&data,1) ==-1 )

This should be:

	if (i2c_read(ADT7460_ADDRESS, dir, 1, &data, 1) == -1)

> +		return -1;
> +	if (data==ADT7460_INVALID)

Again spaces. And more below...

I suggest you run Lindent over this file.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================