[U-Boot-Users] [PATCH 1/1] hwmon: Cleaning hwmon devices

[Stefan Roese <sr@denx.de>]

On Friday 11 July 2008, monstr at seznam.cz wrote:
> From: Michal Simek <monstr@monstr.eu>
>
> Clean Makefile
> Move device specific values to driver for better reading

Thanks. One comment below though:

> Signed-off-by: Michal Simek <monstr@monstr.eu>
> ---
>  drivers/hwmon/Makefile  |   12 ++++----
>  drivers/hwmon/adm1021.c |   35 +++++++++++++++++++--
>  drivers/hwmon/ds1621.c  |   12 +++++--
>  drivers/hwmon/ds1722.c  |    5 ---
>  drivers/hwmon/ds1775.c  |    8 ++--
>  drivers/hwmon/lm73.c    |    6 ++++
>  drivers/hwmon/lm75.c    |    8 ++--
>  drivers/hwmon/lm81.c    |    8 +++--
>  include/dtt.h           |   77
> +--------------------------------------------- 9 files changed, 66
> insertions(+), 105 deletions(-)
>
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index 065433a..61b028f 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -30,13 +30,13 @@ include $(TOPDIR)/config.mk
>
>  LIB	= $(obj)libhwmon.a
>
> -COBJS-y += adm1021.o
> -COBJS-y += ds1621.o
> -COBJS-y += ds1722.o
> -COBJS-y += ds1775.o
> +COBJS-$(CONFIG_DTT_ADM1021) += adm1021.o
> +COBJS-$(CONFIG_DTT_DS1621) += ds1621.o
> +COBJS-$(CONFIG_DS1722) += ds1722.o

CONFIG_DS1722 does not match the "CONFIG_DTT_foo" idea all other sensors are 
using. Perhaps you could fix this up too (CONFIG_DS1722 -> CONFIG_DTT_DS1722) 
with another version of this patch?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================