[U-Boot-Users] [PATCH] ppc4xx: Fix include sequence in 4xx_pcie.c

[Stefan Roese <sr@denx.de>]

Hi Wolfgang,

On Thursday 10 July 2008, Stefan Roese wrote:
> > Hm. I think we have a serious problem when the correctness of the code
> > depends on the include order. It seems that include/asm-ppc/types.h
> > depends on CONFIG_PHYS_64BIT, so include/asm-ppc/types.h must make
> > sure this variable is set correctly, i. e. we should include common.h
> > there.
>
> Yes, I though too that this problem might affect other files too. But
> unfortunately including common.h from within asm/types.h does not work
> since common.h includes (and needs) types.h itself.
>
> I have no elegant solution to handle this in a more generic way right now.
> Perhaps somebody else has? Ideas welcome. :)

Since nobody has come up with a better idea, I suggest we push the current fix 
for now. Same reason as the USB shutdown patch that you pulled even though it 
is not perfect.

Should I put it in my repo and send a pull request?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================