public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH v2] PPC4xx: Correct SDRAM_MCSTAT for PPC405EX(r)
@ 2008-07-09 18:55 Grant Erickson
  2008-07-11 11:23 ` Stefan Roese
  0 siblings, 1 reply; 2+ messages in thread
From: Grant Erickson @ 2008-07-09 18:55 UTC (permalink / raw)
  To: u-boot

While the PowerPC 405EX(r) shares in common the AMCC/IBM DDR2 SDRAM
controller core also used in the 440SP, 440SPe, 460EX, and 460GT, in
the 405EX(r), SDRAM_MCSTAT has a different DCR value.

Its present value on the 405EX(r) causes a read back of 0xFFFFFFFF
which causes SDRAM initialization to periodically fail since it can
prematurely indicate SDRAM ready status.

Signed-off-by: Grant Erickson <gerickson@nuovations.com>
---
 include/asm-ppc/ppc4xx-sdram.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/asm-ppc/ppc4xx-sdram.h b/include/asm-ppc/ppc4xx-sdram.h
index 8a064df..b528497 100644
--- a/include/asm-ppc/ppc4xx-sdram.h
+++ b/include/asm-ppc/ppc4xx-sdram.h
@@ -353,8 +353,11 @@
 /*
  * Memory controller registers
  */
+#ifndef CONFIG_405EX
 #define SDRAM_MCSTAT	0x14	/* memory controller status                  */
+#else
+#define SDRAM_MCSTAT	0x1F	/* memory controller status                  */
+#endif
 #define SDRAM_MCOPT1	0x20	/* memory controller options 1               */
 #define SDRAM_MCOPT2	0x21	/* memory controller options 2               */
 #define SDRAM_MODT0	0x22	/* on die termination for bank 0             */
--
1.5.4.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot-Users] [PATCH v2] PPC4xx: Correct SDRAM_MCSTAT for PPC405EX(r)
  2008-07-09 18:55 [U-Boot-Users] [PATCH v2] PPC4xx: Correct SDRAM_MCSTAT for PPC405EX(r) Grant Erickson
@ 2008-07-11 11:23 ` Stefan Roese
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2008-07-11 11:23 UTC (permalink / raw)
  To: u-boot

On Wednesday 09 July 2008, Grant Erickson wrote:
> While the PowerPC 405EX(r) shares in common the AMCC/IBM DDR2 SDRAM
> controller core also used in the 440SP, 440SPe, 460EX, and 460GT, in
> the 405EX(r), SDRAM_MCSTAT has a different DCR value.
>
> Its present value on the 405EX(r) causes a read back of 0xFFFFFFFF
> which causes SDRAM initialization to periodically fail since it can
> prematurely indicate SDRAM ready status.
>
> Signed-off-by: Grant Erickson <gerickson@nuovations.com>

Applied to "next" branch in u-boot-ppc4xx repository. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-11 11:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-09 18:55 [U-Boot-Users] [PATCH v2] PPC4xx: Correct SDRAM_MCSTAT for PPC405EX(r) Grant Erickson
2008-07-11 11:23 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox