[U-Boot-Users] [PATCH] PPC: Some PCI generalization in the global_data structure.

[Wolfgang Denk <wd@denx.de>]

In message <8496f91a0807130506q329cc35h7934d756fee6b027@mail.gmail.com> you wrote:
> The global_data structure has no well defined method of the PCI clocks
> and other PCI related variables declaration. This patch adds initial
> support for the generalized method based on CONFIG_PCI usage. At present
> it only affects when CONFIG_MPC8272 or CONFIG_MPC8272_FAMILY defined.
> 
> Signed-off-by: Matvejchikov Ilya <matvejchikov@gmail.com>
> ---
>  include/asm-ppc/global_data.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/asm-ppc/global_data.h b/include/asm-ppc/global_data.h
> index c5ac658..ac3e719 100644
> --- a/include/asm-ppc/global_data.h
> +++ b/include/asm-ppc/global_data.h
> @@ -42,6 +42,11 @@ typedef	struct	global_data {
>  	unsigned long	baudrate;
>  	unsigned long	cpu_clk;	/* CPU clock in Hz! */
>  	unsigned long	bus_clk;
> +#ifdef CONFIG_PCI
> +#if defined(CONFIG_MPC8272) || defined(CONFIG_MPC8272_FAMILY)
> +	u32		pci_clk;
> +#endif
> +#endif
>  #if defined(CONFIG_8xx)
>  	unsigned long	brg_clk;
>  #endif

This makes no sense to me.

Please keep in mind that the global_data stuff is intended for, and
only for, holding global information while we are still running from
flash (i. e. before relocation) so that we have neiter a writabel data
segment nor a valid bss segment.

PCI initialization always happens *after* relocation to RAM, therefore
no PCI related variables are ever needed in the global_data structure.

Rejected.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Celestial navigation is based on the premise that the  Earth  is  the
center  of  the  universe.  The  premise is wrong, but the navigation
works. An incorrect model can be a useful tool.   - Kelvin Throop III