From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 15 Jul 2008 10:46:33 +0200 Subject: [U-Boot-Users] [PATCH] cfi_flash: fix flash on Big Endian machines. In-Reply-To: <20080714101829.GA11938@www.tglx.de> References: <20080714101829.GA11938@www.tglx.de> Message-ID: <200807151046.33294.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Sebastian, On Monday 14 July 2008, Sebastian Siewior wrote: > This got broken by commits 93c56f212c > [cfi_flash: support of long cmd in U-boot.] > > That command seems to be access in a little endian way so > wrappers are required. Please explain why this is the case? Little endian wrappers on big endian machines for FLASH access? This sounds wrong to me. > Long is the wrong type because it will behave differently on > 64bit machnines in a way that is probably not expected. > int should be enough. Yes. I suggest that you move this long/int issue to a separate patch. It isn't related to this endian issue. And to you main patch: NAK. After applying this, CFI support on kilauea (PPC405EX with 1* Spansion S29GL512N, 16bit wide) breaks: U-Boot 1.3.3-02016-g3ed7287 (Jul 15 2008 - 10:37:58) CPU: AMCC PowerPC 405EX Rev. C at 533.333 MHz (PLB=177, OPB=88, EBC=88 MHz) Security support Bootstrap Option H - Boot ROM Location I2C (Addr 0x52) 16 kB I-Cache 16 kB D-Cache Board: Kilauea - AMCC PPC405EX Evaluation Board I2C: ready DTT1: 34 C DRAM: 256 MB FLASH: CFI: Unknown command set 0x0 ## Unknown FLASH on Bank 1 - Size = 0x00000000 = 0 MB *** failed *** ### ERROR ### Please RESET the board ### Please explain what exactly you need to fix, perhaps with an example. The current version breaks other boards. /me fetches the BDI to reflash the kilauea... Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================