From: Grant Likely <grant.likely@secretlab.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Remove warnings compiling serial_xuartlite.c
Date: Wed, 16 Jul 2008 07:55:40 -0600 [thread overview]
Message-ID: <20080716135540.GA24045@secretlab.ca> (raw)
In-Reply-To: <1216170093-13146-1-git-send-email-ricardo.ribalda@uam.es>
On Wed, Jul 16, 2008 at 03:01:33AM +0200, Ricardo Ribalda Delgado wrote:
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index 5c41a1c..2e6f096 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -37,9 +37,9 @@
> #define SR_RX_FIFO_VALID_DATA 0x01 /* data in receive FIFO */
> #define SR_RX_FIFO_FULL 0x02 /* receive FIFO full */
>
> -#define UARTLITE_STATUS (CONFIG_SERIAL_BASE + STATUS_REG_OFFSET)
> -#define UARTLITE_TX_FIFO (CONFIG_SERIAL_BASE + TX_FIFO_OFFSET)
> -#define UARTLITE_RX_FIFO (CONFIG_SERIAL_BASE + RX_FIFO_OFFSET)
> +#define UARTLITE_STATUS (u32*)(CONFIG_SERIAL_BASE + STATUS_REG_OFFSET)
> +#define UARTLITE_TX_FIFO (u32*)(CONFIG_SERIAL_BASE + TX_FIFO_OFFSET)
> +#define UARTLITE_RX_FIFO (u32*)(CONFIG_SERIAL_BASE + RX_FIFO_OFFSET)
Nak. Fix the code instead. These constants are correct and should
not be pre-cast in the macro.
g.
next prev parent reply other threads:[~2008-07-16 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 1:01 [U-Boot-Users] [PATCH] Remove warnings compiling serial_xuartlite.c Ricardo Ribalda Delgado
2008-07-16 13:55 ` Grant Likely [this message]
2008-07-16 14:22 ` Ricardo Ribalda Delgado
2008-07-16 14:26 ` Grant Likely
2008-07-20 21:06 ` Wolfgang Denk
2008-07-20 21:33 ` Ricardo Ribalda Delgado
2008-07-23 9:20 ` Haavard Skinnemoen
2008-07-23 13:25 ` Grant Likely
2008-07-24 3:18 ` Wolfgang Denk
2008-07-24 5:07 ` Grant Likely
2008-07-24 7:43 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080716135540.GA24045@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox