public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Remove warnings compiling	serial_xuartlite.c
Date: Wed, 16 Jul 2008 08:26:02 -0600	[thread overview]
Message-ID: <20080716142602.GE24045@secretlab.ca> (raw)
In-Reply-To: <1216218152-16067-1-git-send-email-ricardo.ribalda@uam.es>

On Wed, Jul 16, 2008 at 04:22:32PM +0200, Ricardo Ribalda Delgado wrote:
> Casting on in_be32 not in MACROS
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>

Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> serial_xuartlite.c: In function ?serial_putc?:
> serial_xuartlite.c:59: warning: passing argument 1 of ?in_be32? makes pointer from integer without a cast
> serial_xuartlite.c:60: warning: passing argument 1 of ?out_be32? makes pointer from integer without a cast
> serial_xuartlite.c: In function ?serial_getc?:
> serial_xuartlite.c:72: warning: passing argument 1 of ?in_be32? makes pointer from integer without a cast
> serial_xuartlite.c:73: warning: passing argument 1 of ?in_be32? makes pointer from integer without a cast
> serial_xuartlite.c: In function ?serial_tstc?:
> serial_xuartlite.c:78: warning: passing argument 1 of ?in_be32? makes pointer from integer without a cast
> 
> Previous warnings corrected by this patch
> 
>  drivers/serial/serial_xuartlite.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c
> index 5c41a1c..74546ce 100644
> --- a/drivers/serial/serial_xuartlite.c
> +++ b/drivers/serial/serial_xuartlite.c
> @@ -56,8 +56,8 @@ void serial_putc(const char c)
>  {
>  	if (c == '\n')
>  		serial_putc('\r');
> -	while (in_be32(UARTLITE_STATUS) & SR_TX_FIFO_FULL);
> -	out_be32(UARTLITE_TX_FIFO, (unsigned char) (c & 0xff));
> +	while (in_be32((u32 *) UARTLITE_STATUS) & SR_TX_FIFO_FULL);
> +	out_be32((u32 *) UARTLITE_TX_FIFO, (unsigned char) (c & 0xff));
>  }
>  
>  void serial_puts(const char * s)
> @@ -69,13 +69,13 @@ void serial_puts(const char * s)
>  
>  int serial_getc(void)
>  {
> -	while (!(in_be32(UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA));
> -	return in_be32(UARTLITE_RX_FIFO) & 0xff;
> +	while (!(in_be32((u32 *) UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA));
> +	return in_be32((u32 *) UARTLITE_RX_FIFO) & 0xff;
>  }
>  
>  int serial_tstc(void)
>  {
> -	return (in_be32(UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA);
> +	return (in_be32((u32 *) UARTLITE_STATUS) & SR_RX_FIFO_VALID_DATA);
>  }
>  
>  #endif	/* CONFIG_MICROBLZE */
> -- 
> 1.5.6.2
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users

  reply	other threads:[~2008-07-16 14:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  1:01 [U-Boot-Users] [PATCH] Remove warnings compiling serial_xuartlite.c Ricardo Ribalda Delgado
2008-07-16 13:55 ` Grant Likely
2008-07-16 14:22   ` Ricardo Ribalda Delgado
2008-07-16 14:26     ` Grant Likely [this message]
2008-07-20 21:06     ` Wolfgang Denk
2008-07-20 21:33       ` Ricardo Ribalda Delgado
2008-07-23  9:20         ` Haavard Skinnemoen
2008-07-23 13:25           ` Grant Likely
2008-07-24  3:18           ` Wolfgang Denk
2008-07-24  5:07             ` Grant Likely
2008-07-24  7:43               ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080716142602.GE24045@secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox