[U-Boot-Users] ppc4xx: [PATCH] ML507 Board Support

[Stefan Roese <sr@denx.de>]

On Thursday 17 July 2008, Wolfgang Denk wrote:
> In message <200807170831.57309.sr@denx.de> you wrote:
> > > +phys_size_t initdram(int board_type)
> > > +{
> > > +	return 256 * 1024 * 1024;
> > > +}
> >
> > How about at least defining this SDRAM size in the board header and using
> > it here:
> >
> > board_foo.h:
> > #define CFG_MBYTES_SDRAM        256
>
> No. All boards, especially all PowerPC boards, should use dynamic
> memory size detection.

You are probably referring to calling get_ram_size() instead of just returning 
the configured fixed value. But what do we gain here. get_ram_size() also 
needs the ram-size as parameter. Not sure if this is an improvement on such 
fixed systems.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================