[U-Boot-Users] ppc4xx: [PATCH] ML507 Board Support

Wolfgang Denk
2008-07-29T14:29:29Z

In message <200807171039.38227.sr@denx.de> you wrote:
>
> > > #define CFG_MBYTES_SDRAM 256
> >
> > No. All boards, especially all PowerPC boards, should use dynamic
> > memory size detection.
>
> You are probably referring to calling get_ram_size() instead of just returning
> the configured fixed value. But what do we gain here. get_ram_size() also
> needs the ram-size as parameter. Not sure if this is an improvement on such
> fixed systems.

It just needs a maximum possible size.

One major advantage is for example that get_ram_size() verifies that
RAM is actually working, and of expected size. It is a very efficient
test to make sure your hardware is actually working.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I can call spirits from the vasty deep."
"Why so can I, or so can any man; but will they come when you do call
for them?" - Shakespeare, 1 King Henry IV, Act III, Scene I.