[U-Boot-Users] ppc4xx: [PATCH] ML507 Board Support

Wolfgang Denk
2008-07-17T08:25:59Z

In message <200807170831.57309.sr@denx.de> you wrote:
>
> > +phys_size_t initdram(int board_type)
> > +{
> > + return 256 * 1024 * 1024;
> > +}
>
> How about at least defining this SDRAM size in the board header and using it
> here:
>
> board_foo.h:
> #define CFG_MBYTES_SDRAM 256

No. All boards, especially all PowerPC boards, should use dynamic
memory size detection.

There is no reason to hard-wire the size.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All these theories, diverse as they are, have two things in common:
they explain the observed facts, and they are completeley and utterly
wrong. - Terry Pratchett, _The Light Fantastic_