From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Tue, 29 Jul 2008 09:25:12 +0200
Subject: [U-Boot-Users] [PATCH 1/1] Re-Submit: Add support for ATMEL
	AT91SAM9G20EK	board.
In-Reply-To: <f8328f7c0807282157i7502b04bk7907214e1d872769@mail.gmail.com>
References: <1516faed0807281917s14eb361y30c97dc428ca23b0@mail.gmail.com>
	<f8328f7c0807282157i7502b04bk7907214e1d872769@mail.gmail.com>
Message-ID: <20080729072512.GA18666@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 21:57 Mon 28 Jul     , Ben Warren wrote:
> Hi Hong,
> 
> Thanks for all the hard work.  One more thing...
> <snip>
> > +#if defined(CONFIG_CMD_NET)
> > +int board_eth_init(bd_t *bis)
> > +{
> > +       return at91sam9_eth_initialize(bis);
> > +}
> > +#endif
> 
> Here's at91sam9_eth_initialize:
> 
> #if defined(CONFIG_MACB) && defined(CONFIG_CMD_NET)
> void at91sam9_eth_initialize(bd_t *bi)
> {
>     macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x00);
> }
> #endif
> 
> Issues:
> 1. It returns void
> 2. It just calls the MACB initializer.
> 
> Please change your code to:
> 
> extern int macb_eth_initialize(int id, void *regs, unsigned int phy_addr);
> 
> #if defined(CONFIG_MACB) && defined(CONFIG_CMD_NET)
> int board_eth_init(bd_t *bi)
> {
>     return macb_eth_initialize(0, (void *)AT91_BASE_EMAC, 0x00);
> }
> #endif
> 
> or something like this.  I don't know if AT91_BASE_EMAC is visible
> from this code, so you may need to modify slightly.
Can we do a cpu_eth_init instead?

Best Regards,
J.