[U-Boot] [U-Boot-Users] [PATCH] JFFS2 command support on OneNAND (take #3)

Wolfgang Denk
2008-09-05T22:52:52Z

Dear Fathi BOUDRA,

In message <200808051330.15387.fabo@debian.org> you wrote:
> JFFS2 command support on OneNAND.
>
> - Fix typo.
> - Fix nand_bbt_descr redefinition when NAND and OneNAND are enabled.
>
> Since last comments:
> - Add some CONFIG_CMD_ONENAND to prevent adding new code.
> - Fix line too long.
> - Revert mtd device types definition.
>
> TODO: Use NAND command interface (e.g.: part_validate_*nand()).
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Fathi Boudra <fabo@debian.org>
> ---
> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
> index b4698be..16ca8f7 100644
> --- a/common/cmd_jffs2.c
> +++ b/common/cmd_jffs2.c
> @@ -51,7 +51,7 @@
> * mtdids=<idmap>[,<idmap>,...]
> *
> * <idmap> := <dev-id>=<mtd-id>
> - * <dev-id> := 'nand'|'nor'<dev-num>
> + * <dev-id> := 'nand'|'nor'|'onenand'<dev-num>
> * <dev-num> := mtd device number, 0...
> * <mtd-id> := unique device tag used by linux kernel to find mtd device
> (mtd->name)
^^^^^^^^^^^^^^^^^
Line wrapped.

> *
> @@ -103,6 +103,13 @@
> #include <nand.h>
> #endif /* !CFG_NAND_LEGACY */
> #endif
> +
> +#if defined(CONFIG_CMD_ONENAND)
> +#include <linux/mtd/mtd.h>
> +#include <linux/mtd/onenand.h>
> +#include <onenand_uboot.h>
> +#endif
> +
> /* enable/disable debugging messages */
> #define DEBUG_JFFS
> #undef DEBUG_JFFS
> @@ -401,6 +408,42 @@ static int part_validate_nand(struct mtdids *id, struct
> part_info *part)
^^^^^^^^^^^^^^^^^^^^^^^

Line wrapped.

Sorry, your patch was line-wrapped by your mailer. Please fix your
mailer configuration and resubmit.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Morality is one thing. Ratings are everything."
- A Network 23 executive on "Max Headroom"