From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v3] Add MIMC200 board
Date: Wed, 30 Jul 2008 12:24:14 +0200 [thread overview]
Message-ID: <20080730102414.0F867248A5@gemini.denx.de> (raw)
In-Reply-To: Your message of "Wed, 30 Jul 2008 10:14:34 BST." <489030FA.2030908@mimc.co.uk>
In message <489030FA.2030908@mimc.co.uk> you wrote:
> The MIMC200 board is based on Atmel's NGW100 dev kit, but with an extra 8MByte FLASH and 128KByte FRAM.
> ---
>
> CREDITS | 4 +
> MAINTAINERS | 4 +
> MAKEALL | 1 +
> Makefile | 3 +
> board/mimc/mimc200/Makefile | 40 ++++++++
> board/mimc/mimc200/config.mk | 3 +
> board/mimc/mimc200/mimc200.c | 209 +++++++++++++++++++++++++++++++++++++++++
> board/mimc/mimc200/u-boot.lds | 73 ++++++++++++++
> common/console.c | 5 +
> include/configs/mimc200.h | 177 ++++++++++++++++++++++++++++++++++
> 10 files changed, 519 insertions(+), 0 deletions(-)
Please splitt the changes to common/console.c into a separate patch.
And make sure to explain exactly why this is needed, and why you think
your implementation works (for example, why do you add the test only
to tstc() but not to getc() ?)
Without better explanations I reject the common/console.c part of the
patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
CONSUMER NOTICE: Because of the "Uncertainty Principle," It Is
Impossible for the Consumer to Find Out at the Same Time Both
Precisely Where This Product Is and How Fast It Is Moving.
prev parent reply other threads:[~2008-07-30 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 9:14 [U-Boot-Users] [PATCH v3] Add MIMC200 board Mark Jackson
2008-07-30 10:24 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730102414.0F867248A5@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox