From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] bdinfo not showing correct info about memory size
Date: Wed, 30 Jul 2008 13:04:31 +0200 [thread overview]
Message-ID: <20080730110431.6F189248BF@gemini.denx.de> (raw)
In-Reply-To: Your message of "Wed, 30 Jul 2008 12:42:29 +0200." <1217414549-28700-1-git-send-email-ricardo.ribalda@uam.es>
In message <1217414549-28700-1-git-send-email-ricardo.ribalda@uam.es> you wrote:
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
> ---
> common/cmd_bdinfo.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index caa467d..583bbc2 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -48,7 +48,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> print_num ("bd address", (ulong)bd );
> #endif
> print_num ("memstart", bd->bi_memstart );
> - print_lnum ("memsize", bd->bi_memsize );
> + print_num ("memsize", bd->bi_memsize );
> print_num ("flashstart", bd->bi_flashstart );
> print_num ("flashsize", bd->bi_flashsize );
> print_num ("flashoffset", bd->bi_flashoffset );
This patch is wrong. print_num() takes an ulong argument, but
bi_memsize has type phys_size_t.
Rejected.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you can, help others. If you can't, at least don't hurt others."
- the Dalai Lama
next prev parent reply other threads:[~2008-07-30 11:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 10:42 [U-Boot-Users] [PATCH] bdinfo not showing correct info about memory size Ricardo Ribalda Delgado
2008-07-30 11:04 ` Wolfgang Denk [this message]
2008-07-30 11:10 ` Ricardo Ribalda Delgado
2008-07-30 11:21 ` Wolfgang Denk
2008-07-30 11:34 ` Ricardo Ribalda Delgado
2008-07-30 11:54 ` Wolfgang Denk
2008-07-30 12:08 ` Stefan Roese
2008-07-30 11:54 ` Stefan Roese
2008-07-30 12:09 ` Wolfgang Denk
2008-07-30 12:13 ` Stefan Roese
2008-07-30 12:27 ` [U-Boot-Users] [PATCH] bdinfo not showing correct info aboutmemory size Ricardo
2008-07-31 9:11 ` [U-Boot-Users] [PATCH] bdinfo not showing correct info about memory size Wolfgang Denk
[not found] ` <aa76a2be0809011227t642d7460h9178efef2f1443d6@mail.gmail.com>
2008-09-01 19:28 ` [U-Boot] Fwd: " Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080730110431.6F189248BF@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox