public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] bdinfo not showing correct info about memory size
Date: Wed, 30 Jul 2008 14:09:19 +0200	[thread overview]
Message-ID: <20080730120920.02F3F248EC@gemini.denx.de> (raw)
In-Reply-To: Your message of "Wed, 30 Jul 2008 13:54:50 +0200." <200807301354.50242.sr@denx.de>

In message <200807301354.50242.sr@denx.de> you wrote:
> 
> >   I don't think that it is a problem with my board config, otherwhise
> > it won't show the correct size using print_num...
> >    Maybe other users didn't have any problems because their memory
> > size is smaller than 256MB.
> 
> Most likely you need to enable 64bit printf format (%ll) support:
> 
> #define CFG_64BIT_VSPRINTF
> #define CFG_64BIT_STRTOUL
> 
> This is already done for all 440 PPC's (include/ppc4xx.h) in the current git 
> head. I'll merge this soon into the next branch of my ppc4xx repository, then 
> your problem should go away.

Given the fact that print_lnum() unconditionally takes a u64 arg  and
unconditionally  uses  a  %llX  format,  I  thinkwe shoudl either fix
print_lnum() for non-64bit cases, or drop  the  CFG_64BIT_VSPRINTF  /
CFG_64BIT_STRTOUL options completely.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If God had a beard, he'd be a UNIX programmer.

  reply	other threads:[~2008-07-30 12:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 10:42 [U-Boot-Users] [PATCH] bdinfo not showing correct info about memory size Ricardo Ribalda Delgado
2008-07-30 11:04 ` Wolfgang Denk
2008-07-30 11:10   ` Ricardo Ribalda Delgado
2008-07-30 11:21     ` Wolfgang Denk
2008-07-30 11:34       ` Ricardo Ribalda Delgado
2008-07-30 11:54         ` Wolfgang Denk
2008-07-30 12:08           ` Stefan Roese
2008-07-30 11:54         ` Stefan Roese
2008-07-30 12:09           ` Wolfgang Denk [this message]
2008-07-30 12:13             ` Stefan Roese
2008-07-30 12:27               ` [U-Boot-Users] [PATCH] bdinfo not showing correct info aboutmemory size Ricardo
2008-07-31  9:11               ` [U-Boot-Users] [PATCH] bdinfo not showing correct info about memory size Wolfgang Denk
     [not found]           ` <aa76a2be0809011227t642d7460h9178efef2f1443d6@mail.gmail.com>
2008-09-01 19:28             ` [U-Boot] Fwd: " Ricardo Ribalda Delgado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080730120920.02F3F248EC@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox