[U-Boot-Users] [PATCH 4/7] USB: Add support for OHCI controller on s3c6400

[U-Boot-Users] [PATCH 4/7] USB: Add support for OHCI controller on s3c6400

[Guennadi Liakhovetski]

Notice: USB on s3c6400 currently works _only_ with switched off MMU. One could
try to enable the MMU, but map addresses 1-to-1, and disable data cache, then
it should work too and we could still profit from instruction cache.

Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
---
 cpu/arm1176/s3c64xx/Makefile |    1 +
 cpu/arm1176/s3c64xx/usb.c    |   44 ++++++++++++++++++++++++++++++++++++++++++
 drivers/usb/usb_ohci.c       |    1 +
 3 files changed, 46 insertions(+), 0 deletions(-)
 create mode 100644 cpu/arm1176/s3c64xx/usb.c

diff --git a/cpu/arm1176/s3c64xx/Makefile b/cpu/arm1176/s3c64xx/Makefile
index 92373d8..0a1201d 100644
--- a/cpu/arm1176/s3c64xx/Makefile
+++ b/cpu/arm1176/s3c64xx/Makefile
@@ -28,6 +28,7 @@ LIB	= $(obj)lib$(SOC).a
 OBJS	= interrupts.o
 #OBJS	= nand_cp.o serial.o usb_ohci.o interrupts.o nand.o
 COBJS-$(CONFIG_S3C6400)	+= cpu_init.o speed.o
+COBJS-$(CONFIG_USB_OHCI_NEW) += usb.o
 
 OBJS	+= $(COBJS-y)
 
diff --git a/cpu/arm1176/s3c64xx/usb.c b/cpu/arm1176/s3c64xx/usb.c
new file mode 100644
index 0000000..f9dbc5e
--- /dev/null
+++ b/cpu/arm1176/s3c64xx/usb.c
@@ -0,0 +1,44 @@
+/*
+ * URB OHCI HCD (Host Controller Driver) initialization for USB on the S3C64XX.
+ *
+ * Copyright (C) 2008, Guennadi Liakhovetski, DENX Software Engineering <lg@denx.de>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+#include <common.h>
+#include <s3c6400.h>
+
+int usb_cpu_init(void)
+{
+	OTHERS_REG |= 0x10000;
+	return 0;
+}
+
+int usb_cpu_stop(void)
+{
+	OTHERS_REG &= ~0x10000;
+	return 0;
+}
+
+void usb_cpu_init_fail(void)
+{
+	OTHERS_REG &= ~0x10000;
+}
diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c
index fd60edb..94549a8 100644
--- a/drivers/usb/usb_ohci.c
+++ b/drivers/usb/usb_ohci.c
@@ -67,6 +67,7 @@
 #endif
 
 #if defined(CONFIG_ARM920T) || \
+    defined(CONFIG_S3C6400) || \
     defined(CONFIG_S3C2400) || \
     defined(CONFIG_S3C2410) || \
     defined(CONFIG_440EP) || \
-- 
1.5.4

[U-Boot-Users] [PATCH 4/7] USB: Add support for OHCI controller on s3c6400

[Wolfgang Denk]

In message <Pine.LNX.4.64.0807311244130.4832@axis700.grange> you wrote:
> Notice: USB on s3c6400 currently works _only_ with switched off MMU. One could
> try to enable the MMU, but map addresses 1-to-1, and disable data cache, then
> it should work too and we could still profit from instruction cache.
> 
> Signed-off-by: Guennadi Liakhovetski <lg@denx.de>

...
> diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c
> index fd60edb..94549a8 100644
> --- a/drivers/usb/usb_ohci.c
> +++ b/drivers/usb/usb_ohci.c
> @@ -67,6 +67,7 @@
>  #endif
>  
>  #if defined(CONFIG_ARM920T) || \
> +    defined(CONFIG_S3C6400) || \
>      defined(CONFIG_S3C2400) || \
>      defined(CONFIG_S3C2410) || \
>      defined(CONFIG_440EP) || \

Please keep the list sorted.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Wish not to seem, but to be, the best."                  - Aeschylus

[U-Boot-Users] [PATCH 4/7] USB: Add support for OHCI controller on s3c6400

[Jean-Christophe PLAGNIOL-VILLARD]

On 12:54 Thu 31 Jul     , Guennadi Liakhovetski wrote:
> Notice: USB on s3c6400 currently works _only_ with switched off MMU. One could
> try to enable the MMU, but map addresses 1-to-1, and disable data cache, then
> it should work too and we could still profit from instruction cache.
> 
> Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
> ---
>  cpu/arm1176/s3c64xx/Makefile |    1 +
>  cpu/arm1176/s3c64xx/usb.c    |   44 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/usb/usb_ohci.c       |    1 +
>  3 files changed, 46 insertions(+), 0 deletions(-)
>  create mode 100644 cpu/arm1176/s3c64xx/usb.c
> 
> diff --git a/cpu/arm1176/s3c64xx/Makefile b/cpu/arm1176/s3c64xx/Makefile
> index 92373d8..0a1201d 100644
> --- a/cpu/arm1176/s3c64xx/Makefile
> +++ b/cpu/arm1176/s3c64xx/Makefile
> @@ -28,6 +28,7 @@ LIB	= $(obj)lib$(SOC).a
>  OBJS	= interrupts.o
>  #OBJS	= nand_cp.o serial.o usb_ohci.o interrupts.o nand.o
If no need please remove put it as conditional
>  COBJS-$(CONFIG_S3C6400)	+= cpu_init.o speed.o
> +COBJS-$(CONFIG_USB_OHCI_NEW) += usb.o
>  
>  OBJS	+= $(COBJS-y)
>  
> diff --git a/cpu/arm1176/s3c64xx/usb.c b/cpu/arm1176/s3c64xx/usb.c
> new file mode 100644
> index 0000000..f9dbc5e
> --- /dev/null
> +++ b/cpu/arm1176/s3c64xx/usb.c
> @@ -0,0 +1,44 @@
> +/*
> + * URB OHCI HCD (Host Controller Driver) initialization for USB on the S3C64XX.
> + *
> + * Copyright (C) 2008, Guennadi Liakhovetski, DENX Software Engineering <lg@denx.de>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + *
> + */
> +
> +#include <common.h>
> +#include <s3c6400.h>
> +
> +int usb_cpu_init(void)
> +{
> +	OTHERS_REG |= 0x10000;
> +	return 0;
> +}
> +
> +int usb_cpu_stop(void)
> +{
> +	OTHERS_REG &= ~0x10000;
> +	return 0;
> +}
> +
> +void usb_cpu_init_fail(void)
> +{
> +	OTHERS_REG &= ~0x10000;
> +}
> diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c
> index fd60edb..94549a8 100644
> --- a/drivers/usb/usb_ohci.c
> +++ b/drivers/usb/usb_ohci.c
> @@ -67,6 +67,7 @@
>  #endif
>  
>  #if defined(CONFIG_ARM920T) || \
> +    defined(CONFIG_S3C6400) || \
>      defined(CONFIG_S3C2400) || \
>      defined(CONFIG_S3C2410) || \
>      defined(CONFIG_440EP) || \
Could we find a better way than add and add more defined?

Best Regards,
J.