public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH]:Enable 2D Engine in SM501 to hurry up fresh speed!
Date: Fri, 01 Aug 2008 09:58:46 +0200	[thread overview]
Message-ID: <20080801075846.4FD92248BF@gemini.denx.de> (raw)
In-Reply-To: Your message of "Fri, 01 Aug 2008 10:57:58 +0800." <000101c8f382$6761a650$30065e0a@SHZ.ST.COM>

In message <000101c8f382$6761a650$30065e0a@SHZ.ST.COM> you wrote:
> Hi  Wolfgang,
> I have modified my patch. New macro "CONFIG_SM501_ENABLE_2DENGINE" be
> included to specify codes what enable SM501 2D engine. The macro need be
> declared in config header file.
> Why does it need to enable 2D engine? The reason is most of framebuffer
> contents need be moved in VRAM when screen scrolls up. The work be done by
> software in current U-Boot for SM501. The patch is to enable 2D engine to do
> it by hardware without CPU interference.  
> 
> Signed-off-by: Ryan Chen <ryan.chen@st.com>

Also note that there are coding style violations: trailing white
space, indentation/vertical alignment by spaces instead of TABs,
incorrect vertical alignment of "switch" / "case".

Please fix these before you resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"At least they're __________EXPERIENCED incompetents"

      parent reply	other threads:[~2008-08-01  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30  6:14 [U-Boot-Users] [PATCH]:Enable 2D Engine in SM501 to hurry up fresh speed! Ryan CHEN
2008-07-30  8:10 ` Wolfgang Denk
2008-08-01  2:57   ` Ryan CHEN
2008-08-01  7:54     ` Wolfgang Denk
2008-08-01  7:58     ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080801075846.4FD92248BF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox