From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fathi BOUDRA <fabo@debian.org>
Date: Wed, 6 Aug 2008 18:32:04 +0200
Subject: [U-Boot-Users] [PATCH] Fill in remaining MTD driver data for
	OneNAND (take #2)
Message-ID: <200808061832.04718.fabo@debian.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> Don't cast the return of malloc.

ok.

> Why not just declare a static array?

I tried with a static array but it doesn't give the expected result (a quick 
test with onenand info command returns an empty mtd name), so I used a 
pointer.

> It'd be better to use snprintf, even if you're pretty sure it won't
> overflow.

I tried it too :) U-Boot doesn't have snprintf or asprintf or I missed 
something.

Do I need to re-submit the patch only for cast ?

cheers,

Fathi