[U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 14:19 Wed 06 Aug     , Magnus Lilja wrote:
> Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
> 3DS) board.
> 
> Booting from NAND is not supported yet so U-boot relies on some other
> initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.
> 
> Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com>
> ---
>  MAKEALL                       |    1 +
>  Makefile                      |    3 +
>  board/mx31pdk/Makefile        |   53 ++++++++++++
>  board/mx31pdk/config.mk       |    1 +
>  board/mx31pdk/lowlevel_init.S |   30 +++++++
>  board/mx31pdk/mx31pdk.c       |   76 +++++++++++++++++
>  board/mx31pdk/u-boot.lds      |   59 +++++++++++++
>  include/configs/mx31pdk.h     |  186 +++++++++++++++++++++++++++++++++++++++++
>  8 files changed, 409 insertions(+), 0 deletions(-)
> 
> diff --git a/MAKEALL b/MAKEALL
> index ee83cca..ac2d3a8 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -515,6 +515,7 @@ LIST_ARM11="		\
>  	imx31_litekit	\
>  	imx31_phycore	\
>  	mx31ads		\
> +	mx31pdk		\
>  "
>  
>  #########################################################################
> diff --git a/Makefile b/Makefile
> index cb8c0f5..40bd9e1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2683,6 +2683,9 @@ imx31_phycore_config	: unconfig
>  mx31ads_config		: unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
>  
> +mx31pdk_config		: unconfig
> +	@$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk NULL mx31
> +
I've just send a patch to move all freescale's mx31 board to vendor dir

so please replace with 
+mx31pdk_config		: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk freescale mx31
+
>  omap2420h4_config	: unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
>  
> diff --git a/board/mx31pdk/Makefile b/board/mx31pdk/Makefile
and move your board to 
board/freescale/mx31pdk/

> diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
> new file mode 100644
> index 0000000..d1f44ab
> --- /dev/null
> +++ b/include/configs/mx31pdk.h
> @@ -0,0 +1,186 @@
> +/*
> + * (C) Copyright 2008 Magnus Lilja <lilja.magnus@gmail.com>
> + *
> + * (C) Copyright 2004
> + * Texas Instruments.
> + * Richard Woodruff <r-woodruff2@ti.com>
> + * Kshitij Gupta <kshitij@ti.com>
> + *
> + * Configuration settings for the Freescale i.MX31 PDK board.
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#include <asm/arch/mx31-regs.h>
> +
> + /* High Level Configuration Options */
> +#define CONFIG_ARM1136		1    /* This is an arm1136 CPU core */
> +#define CONFIG_MX31		1    /* in a mx31 */
> +#define CONFIG_MX31_HCLK_FREQ	26000000
> +#define CONFIG_MX31_CLK32	32768
> +
> +#define CONFIG_MX31_NAND		1
> +
> +#define CONFIG_DISPLAY_CPUINFO
> +#define CONFIG_DISPLAY_BOARDINFO
> +
> +/* Temporarily disabled */
> +#if 0
> +#define CONFIG_OF_LIBFDT		1
> +#define CONFIG_FIT			1
> +#define CONFIG_FIT_VERBOSE		1
> +#endif
so please remove
> +
> +#define CONFIG_CMDLINE_TAG		1    /* enable passing of ATAGs */
> +#define CONFIG_SETUP_MEMORY_TAGS	1
> +#define CONFIG_INITRD_TAG		1
> +
> +/*
> + * Size of malloc() pool
> + * An extra 128kbyte is needed for the NAND Bad Block table.
> + */
> +#define CFG_MALLOC_LEN		(CFG_ENV_SIZE + 128 * 1024 + 128 * 1024)
> +#define CFG_GBL_DATA_SIZE	128  /* bytes reserved for initial data */
> +
> +/*
> + * Hardware drivers
> + */
> +
> +#define CONFIG_MX31_UART	1
> +#define CFG_MX31_UART1		1
> +
> +#define CONFIG_HARD_SPI		1
> +#define CONFIG_MXC_SPI		1
> +#define CONFIG_MXC_SPI_IFACE	1
> +
> +#define CONFIG_RTC_MC13783	1
> +
> +/* allow to overwrite serial and ethaddr */
> +#define CONFIG_ENV_OVERWRITE
> +#define CONFIG_CONS_INDEX	1
> +#define CONFIG_BAUDRATE		115200
> +#define CFG_BAUDRATE_TABLE	{9600, 19200, 38400, 57600, 115200}
> +
> +/***********************************************************
> + * Command definition
> + ***********************************************************/
> +
> +#include <config_cmd_default.h>
> +
> +/* No support for NAND boot for i.MX31 PDK yet, so we rely on some other
> + * program to initialize the SDRAM.
> + */
> +#define CONFIG_SKIP_LOWLEVEL_INIT
> +
> +#define CONFIG_CMD_MII
> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_SPI
> +#define CONFIG_CMD_DATE
> +
> +#define CONFIG_CMD_NAND 1
why not
#define CONFIG_CMD_NAND

the check is ifdef

> +#define CFG_HZ			CONFIG_MX31_CLK32
> +
> +#define CONFIG_CMDLINE_EDITING	1
> +
> +#undef CONFIG_CMD_IMLS
please regroup CONFIG_CMD_*

Best Regards,
J.