From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] video: fix bug in logo_plot
Date: Sat, 9 Aug 2008 10:21:59 +0200 [thread overview]
Message-ID: <20080809082159.GB18040@game.jcrosoft.org> (raw)
In-Reply-To: <1218211240-21667-1-git-send-email-agust@denx.de>
On 18:00 Fri 08 Aug , Anatolij Gustschin wrote:
> If logo_plot() should ever be called with x starting
> position other than zero and for pixel depths greater
> than 8bpp, logo colors distortion will be observed.
> This patch fixes the issue.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> drivers/video/cfb_console.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index 68b9861..97a37ba 100644
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
> @@ -1071,7 +1071,9 @@ void logo_plot (void *screen, int width, int x, int y)
> int ycount = VIDEO_LOGO_HEIGHT;
> unsigned char r, g, b, *logo_red, *logo_blue, *logo_green;
> unsigned char *source;
> - unsigned char *dest = (unsigned char *)screen + ((y * width * VIDEO_PIXEL_SIZE) + x);
> + unsigned char *dest = (unsigned char *)screen +
> + ((y * width * VIDEO_PIXEL_SIZE) +
> + x * VIDEO_PIXEL_SIZE);
why not simplify it?
> + unsigned char *dest = (unsigned char *)screen +
> + ((y * width + x) * VIDEO_PIXEL_SIZE);
>
> #ifdef CONFIG_VIDEO_BMP_LOGO
> source = bmp_logo_bitmap;
> --
> 1.5.4.3
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
next prev parent reply other threads:[~2008-08-09 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 16:00 [U-Boot] [PATCH 1/2] video: fix bug in logo_plot Anatolij Gustschin
2008-08-08 16:00 ` [U-Boot] [PATCH 2/2] video: fix bug in cfb_console code Anatolij Gustschin
2008-08-10 22:25 ` Wolfgang Denk
2008-08-09 8:21 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-08-09 9:13 ` [U-Boot] [PATCH 1/2] video: fix bug in logo_plot Anatolij Gustschin
2008-08-10 22:24 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809082159.GB18040@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox