public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH] OneNAND: Remove base address offset usage
Date: Sun, 10 Aug 2008 22:45:52 +0200	[thread overview]
Message-ID: <20080810204552.98DDD248AC@gemini.denx.de> (raw)
In-Reply-To: <1218383796-16876-1-git-send-email-dirk.behme@gmail.com>

Dear Dirk,

In message <1218383796-16876-1-git-send-email-dirk.behme@gmail.com> you wrote:
> While locally preparing some U-Boot patches for ARM based OMAP3 boards, some
> using OneNAND and some using NAND, we found some differences in OneNAND and
> NAND command address handling.
> 
> As this might confuse users (it already confused us), we like to align OneNAND
> and NAND address handling.
> 
> The issue is that cmd_onenand.c subtracts the onenand base address from the
> addresses you type into the u-boot command line so, unlike nand, you can't
> use addresses relative to the start of the onenand part e.g. this won't work:
> 
> onenand read 82000000 280000 400000
> 
> you have to use:
> 
> onenand read 82000000 20280000 400000
> 
> Looking at recent git, the only board currently using OneNAND is Apollon, and
> for this the OneNAND base address is 0 (apollon.h)
> 
> #define	CFG_ONENAND_BASE	0x00000000
> 
> so patch below won't break any existing boards and will align OneNAND and NAND
> handling on boards where OneNAND base address is != 0.
> 
> Signed-off-by: Steve Sakoman <sakoman@gmail.com>
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Crash programs fail because they are based on the theory  that,  with
nine women pregnant, you can get a baby a month.  - Wernher von Braun

      reply	other threads:[~2008-08-10 20:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-10 15:56 [U-Boot] [RFC][PATCH] OneNAND: Remove base address offset usage dirk.behme at googlemail.com
2008-08-10 20:45 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080810204552.98DDD248AC@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox