[U-Boot-Users] [PATCH] Sequoia has two UARTs in "4-pin" mode. Configure the GPIOs as per schematic.

[U-Boot-Users] [PATCH] Sequoia has two UARTs in "4-pin" mode. Configure the GPIOs as per schematic.

[Steven A. Falco]

The Sequoia board has two UARTs in "4-pin" mode.  This patch modifies the GPIO
configuration to match the schematic, and also sets the sdr0_pfc1 register to
select the corresponding mode for the UARTs.

 board/amcc/sequoia/sequoia.c |    5 +++++
 include/configs/sequoia.h    |   12 ++++++------
 2 files changed, 11 insertions(+), 6 deletions(-)

Signed-off-by: Steven A. Falco <sfalco@harris.com>

diff --git a/board/amcc/sequoia/sequoia.c b/board/amcc/sequoia/sequoia.c
index 6bcb3ab..6ee9c88 100644
--- a/board/amcc/sequoia/sequoia.c
+++ b/board/amcc/sequoia/sequoia.c
@@ -93,6 +93,11 @@ int board_early_init_f(void)
 #ifdef CONFIG_I2C_MULTI_BUS
 	sdr0_pfc1 |= ((sdr0_pfc1 & ~SDR0_PFC1_SIS_MASK) | SDR0_PFC1_SIS_IIC1_SEL);
 #endif
+	/* Two UARTs, so we need 4-pin mode.  Also, we want CTS/RTS mode. */
+	sdr0_pfc1 = (sdr0_pfc1 & ~SDR0_PFC1_U0IM_MASK) | SDR0_PFC1_U0IM_4PINS;
+	sdr0_pfc1 = (sdr0_pfc1 & ~SDR0_PFC1_U0ME_MASK) | SDR0_PFC1_U0ME_CTS_RTS;
+	sdr0_pfc1 = (sdr0_pfc1 & ~SDR0_PFC1_U1ME_MASK) | SDR0_PFC1_U1ME_CTS_RTS;
+
 	mfsdr(SDR0_PFC2, sdr0_pfc2);
 	sdr0_pfc2 = (sdr0_pfc2 & ~SDR0_PFC2_SELECT_MASK) |
 		SDR0_PFC2_SELECT_CONFIG_4;
diff --git a/include/configs/sequoia.h b/include/configs/sequoia.h
index 555316f..d129a58 100644
--- a/include/configs/sequoia.h
+++ b/include/configs/sequoia.h
@@ -544,12 +544,12 @@
 /* GPIO Core 1 */									\
 {GPIO1_BASE, GPIO_OUT, GPIO_ALT1, GPIO_OUT_1}, /* GPIO32 USB2D_OPMODE0	EBC_DATA(2)	*/	\
 {GPIO1_BASE, GPIO_OUT, GPIO_ALT1, GPIO_OUT_1}, /* GPIO33 USB2D_OPMODE1	EBC_DATA(3)	*/	\
-{GPIO1_BASE, GPIO_OUT, GPIO_ALT3, GPIO_OUT_1}, /* GPIO34 UART0_DCD_N	UART1_DSR_CTS_N	UART2_SOUT*/ \
-{GPIO1_BASE, GPIO_IN , GPIO_ALT3, GPIO_OUT_0}, /* GPIO35 UART0_8PIN_DSR_N UART1_RTS_DTR_N UART2_SIN*/ \
-{GPIO1_BASE, GPIO_IN , GPIO_ALT3, GPIO_OUT_0}, /* GPIO36 UART0_8PIN_CTS_N EBC_DATA(0)	UART3_SIN*/ \
-{GPIO1_BASE, GPIO_BI , GPIO_ALT2, GPIO_OUT_0}, /* GPIO37 UART0_RTS_N	EBC_DATA(1)	UART3_SOUT*/ \
-{GPIO1_BASE, GPIO_OUT, GPIO_ALT2, GPIO_OUT_1}, /* GPIO38 UART0_DTR_N	UART1_SOUT	*/	\
-{GPIO1_BASE, GPIO_IN , GPIO_ALT2, GPIO_OUT_0}, /* GPIO39 UART0_RI_N	UART1_SIN	*/	\
+{GPIO1_BASE, GPIO_IN , GPIO_ALT2, GPIO_OUT_0}, /* GPIO34 UART0_8PIN_DCD_N UART1_DSR_CTS_N UART2_SOUT*/ \
+{GPIO1_BASE, GPIO_OUT, GPIO_ALT2, GPIO_OUT_1}, /* GPIO35 UART0_8PIN_DSR_N UART1_RTS_DTR_N UART2_SIN*/ \
+{GPIO1_BASE, GPIO_IN , GPIO_ALT1, GPIO_OUT_0}, /* GPIO36 UART0_CTS_N	EBC_DATA(0)	UART3_SIN*/ \
+{GPIO1_BASE, GPIO_OUT, GPIO_ALT1, GPIO_OUT_1}, /* GPIO37 UART0_RTS_N	EBC_DATA(1)	UART3_SOUT*/ \
+{GPIO1_BASE, GPIO_OUT, GPIO_ALT2, GPIO_OUT_1}, /* GPIO38 UART0_8PIN_DTR_N UART1_SOUT	*/	\
+{GPIO1_BASE, GPIO_IN , GPIO_ALT2, GPIO_OUT_0}, /* GPIO39 UART0_8PIN_RI_N UART1_SIN	*/	\
 {GPIO1_BASE, GPIO_IN , GPIO_ALT1, GPIO_OUT_0}, /* GPIO40 UIC_IRQ(0)			*/	\
 {GPIO1_BASE, GPIO_IN , GPIO_ALT1, GPIO_OUT_0}, /* GPIO41 UIC_IRQ(1)			*/	\
 {GPIO1_BASE, GPIO_IN , GPIO_ALT1, GPIO_OUT_0}, /* GPIO42 UIC_IRQ(2)			*/	\
-- 
1.5.5.1

[U-Boot-Users] [PATCH] Sequoia has two UARTs in "4-pin" mode. Configure the GPIOs as per schematic.

[Stefan Roese]

On Wednesday 06 August 2008, Steven A. Falco wrote:
> The Sequoia board has two UARTs in "4-pin" mode.  This patch modifies the
> GPIO configuration to match the schematic, and also sets the sdr0_pfc1
> register to select the corresponding mode for the UARTs.
>
>  board/amcc/sequoia/sequoia.c |    5 +++++
>  include/configs/sequoia.h    |   12 ++++++------
>  2 files changed, 11 insertions(+), 6 deletions(-)
>
> Signed-off-by: Steven A. Falco <sfalco@harris.com>

Applied to u-boot-ppc4xx repository. Thanks.

Note that your s-o-b line should be *above* the patch statistics. Did you 
generate this patch using git-format-patch?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [U-Boot-Users] [PATCH] Sequoia has two UARTs in "4-pin" mode. Configure the GPIOs as per schematic.

[Wolfgang Denk]

Dear Stefan Roese,

In message <200808071209.38651.sr@denx.de> you wrote:
> On Wednesday 06 August 2008, Steven A. Falco wrote:
> > The Sequoia board has two UARTs in "4-pin" mode.  This patch modifies the
> > GPIO configuration to match the schematic, and also sets the sdr0_pfc1
> > register to select the corresponding mode for the UARTs.
> >
> >  board/amcc/sequoia/sequoia.c |    5 +++++
> >  include/configs/sequoia.h    |   12 ++++++------
> >  2 files changed, 11 insertions(+), 6 deletions(-)
> >
> > Signed-off-by: Steven A. Falco <sfalco@harris.com>
> 
> Applied to u-boot-ppc4xx repository. Thanks.

Hmmm... I'm still waiting for your pull request?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fascinating is a word I use for the unexpected.
	-- Spock, "The Squire of Gothos", stardate 2124.5

[U-Boot] [U-Boot-Users] [PATCH] Sequoia has two UARTs in "4-pin" mode. Configure the GPIOs as per schematic.

[Stefan Roese]

Hi Wolfgang,

On Monday 11 August 2008, Wolfgang Denk wrote:
> > On Wednesday 06 August 2008, Steven A. Falco wrote:
> > > The Sequoia board has two UARTs in "4-pin" mode.  This patch modifies
> > > the GPIO configuration to match the schematic, and also sets the
> > > sdr0_pfc1 register to select the corresponding mode for the UARTs.
> > >
> > >  board/amcc/sequoia/sequoia.c |    5 +++++
> > >  include/configs/sequoia.h    |   12 ++++++------
> > >  2 files changed, 11 insertions(+), 6 deletions(-)
> > >
> > > Signed-off-by: Steven A. Falco <sfalco@harris.com>
> >
> > Applied to u-boot-ppc4xx repository. Thanks.
>
> Hmmm... I'm still waiting for your pull request?

I thought since I already missed the Friday deadline it was too late. OK, pull 
request will follow directly.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [U-Boot-Users] [PATCH] Sequoia has two UARTs in "4-pin" mode. Configure the GPIOs as per schematic.

[Wolfgang Denk]

Dear Stefan Roese,

In message <200808110649.38615.sr@denx.de> you wrote:
> 
> > Hmmm... I'm still waiting for your pull request?
> 
> I thought since I already missed the Friday deadline it was too late. OK, pull 

Seems everybody thinks so :-(

> request will follow directly.

Thanks. 

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Children are natural mimics who act like their parents despite  every
effort to teach them good manners.