[U-Boot] [PATCH] ppc4xx: Optimize PLB4 arbiter and Memory Queue settings for PPC 440SP/SPe and 460EX/GT/SX

[Stefan Roese <sr@denx.de>]

On Tuesday 12 August 2008, Prodyut Hazarika wrote:
> Thanks Stefan. Please see replies below.
>
> > Patch is line-wrapped this time. I suggest that you use git-send-email to
> > send your git formatted patches.
>
> I will use git-send-email next time to avoid these issues

Good.

> >> +    defined (CONFIG_460GT) || defined(CONFIG_460SX)
> >
> >No space after "defined" please. -> "defined("
>
> Sorry about that. I will be careful in future.
>
> >> +#if defined(CONFIG_440SP) || defined(CONFIG_440SPE) || \
> >> +    defined(CONFIG_460EX) || defined(CONFIG_460GT)  || \
> >> +    defined(CONFIG_405EX) || defined(CONFIG_460SX)
> >
> > Why don't you add 440GP and 440GX here? From my understanding they would
> > benefit from this pipeline change too.
>
> 400GP/GX have a slightly different register layout. I plan to make a
> separate patch adding the defines and the changes in a separate patch.

That's what I thought. OK.

> >> +#define plb0_revid                (PLB_ARBITER_BASE+ 0x00)
> >> +#define plb0_acr                  (PLB_ARBITER_BASE+ 0x01)
> >
> >No upper case defines in this patch. I'm fine with this as long as we
> > update this in a later patch.
>
> I plan to make a cleanup patch soon. Felt it was appropriate to separate
> them.

Good. Thanks.

> >And from a quick check of the manuals the 440GP/GX have a slightly
> > different register layout. Is this the reason you didn't include those
> > PPC's in this patch version? What are your plans for those PPC's?
>
> That is right. I want to send a separate patch for the same.

OK.

> Also could you please let me know whether you applied the patch. Sorry for
> the line wrap issues - I will use git-send-email next time.

No, I didn't apply it yet. Please fix the nitpicking issues and re-send via 
git-send-email. I'll apply it then.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================