From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] setting pio modes for IDE devices
Date: Thu, 14 Aug 2008 01:20:20 +0200 [thread overview]
Message-ID: <20080813232020.1BCC6248CD@gemini.denx.de> (raw)
In-Reply-To: <48A35533.1010901@harris.com>
Dear "Steven A. Falco",
In message <48A35533.1010901@harris.com> you wrote:
> The following patch adds the ability to call-out from the ide_ident
> routine to a board-specific routine to set the PIO mode of an attached
> device.
>
> This feature is controlled by the preprocessor variable CONFIG_TUNE_CFA.
What does CFA mean?
> cmd_ide.c is modified to use the "drive identify information" read from the
> device to compute a pio mode in the range 0 to 6. This is then passed
> to a board-specific routine, ide_set_piomode, to set the mode in
> hardware.
>
> Two other files are touched: file ata.h, to include word 163, which is the
> "advanced CF parameters", and file ide.h, to add a prototype for the
> board-specific routine (again controlled by the CONFIG_TUNE_CFA
> variable).
Is there a specific reason for using #ifdef's instead of a weak
function?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Conceptual integrity in turn dictates that the design must proceed
from one mind, or from a very small number of agreeing resonant
minds. - Frederick Brooks Jr., "The Mythical Man Month"
next prev parent reply other threads:[~2008-08-13 23:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 21:42 [U-Boot] [RFC] setting pio modes for IDE devices Steven A. Falco
2008-08-13 23:20 ` Wolfgang Denk [this message]
2008-08-14 14:33 ` Steven A. Falco
2008-08-14 16:42 ` Jean-Christophe PLAGNIOL-VILLARD
2008-08-15 15:23 ` Steven A. Falco
2008-08-15 17:53 ` Steven A. Falco
2008-08-15 18:12 ` Wolfgang Denk
2008-08-15 19:29 ` [U-Boot] [Patch 1/3] " Steven A. Falco
2008-08-20 23:21 ` Wolfgang Denk
2008-08-15 19:34 ` [U-Boot] [PATCH 2/3] " Steven A. Falco
2008-08-20 23:31 ` Wolfgang Denk
2008-08-15 19:37 ` [U-Boot] [PATCH 3/3] " Steven A. Falco
2008-08-20 23:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080813232020.1BCC6248CD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox