From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] setting pio modes for IDE devices
Date: Fri, 15 Aug 2008 20:12:30 +0200 [thread overview]
Message-ID: <20080815181230.89BDB248CD@gemini.denx.de> (raw)
In-Reply-To: <48A5C296.1060801@harris.com>
Dear "Steven A. Falco",
In message <48A5C296.1060801@harris.com> you wrote:
> I realized that I should be checking to see if word 163 is applicable to
> the ATA device in question. To do that, I need to call ata_id_is_cfa() from
> libata.h. However, libata.h conflicts with ata.h because of duplicate
> enum values.
>
> Therefore, this respin of the proposed patch deletes the duplicate enums
> from ata.h and instead includes libata.h to supply the enums. Then, I
> can call ata_id_is_cfa() and more accurately detect PIO 5 and 6.
>
> I believe cleaning up ata.h is a good thing, because duplicating the enums in
> both places invites them to get out of sync.
It is, but can you please split this into two independent patches?
Thanks in advance.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A father doesn't destroy his children.
-- Lt. Carolyn Palamas, "Who Mourns for Adonais?",
stardate 3468.1.
next prev parent reply other threads:[~2008-08-15 18:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 21:42 [U-Boot] [RFC] setting pio modes for IDE devices Steven A. Falco
2008-08-13 23:20 ` Wolfgang Denk
2008-08-14 14:33 ` Steven A. Falco
2008-08-14 16:42 ` Jean-Christophe PLAGNIOL-VILLARD
2008-08-15 15:23 ` Steven A. Falco
2008-08-15 17:53 ` Steven A. Falco
2008-08-15 18:12 ` Wolfgang Denk [this message]
2008-08-15 19:29 ` [U-Boot] [Patch 1/3] " Steven A. Falco
2008-08-20 23:21 ` Wolfgang Denk
2008-08-15 19:34 ` [U-Boot] [PATCH 2/3] " Steven A. Falco
2008-08-20 23:31 ` Wolfgang Denk
2008-08-15 19:37 ` [U-Boot] [PATCH 3/3] " Steven A. Falco
2008-08-20 23:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815181230.89BDB248CD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox