public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot-Users] PATCH: Update U-Boot EXT2 Filesystem to support dynamic inode size and optimize ext2 read function to fasten read speed!
Date: Mon, 18 Aug 2008 23:58:53 +0200	[thread overview]
Message-ID: <20080818215853.C0D1824899@gemini.denx.de> (raw)
In-Reply-To: <008501c8f1e8$042046f0$30065e0a@SHZ.ST.COM>

Dear Ryan CHEN,

In message <008501c8f1e8$042046f0$30065e0a@SHZ.ST.COM> you wrote:
> Hi Wolfgang,
> I have modified my patch according to your suggestion. The only question is
> that use debug() because I found all debug print msg lines are written as :
> #ifdef DEBUG
> printf(......);
> #endif
> Are you sure I need change my debug print to debug()?

Since all the other code is like that I agree to leave it unchanged.

But:

> @@ -66,6 +67,17 @@ extern int ext2fs_devread (int sector, int byte_offset,
> int byte_len,
^^^^^^^^^^^^^^

> @@ -226,10 +242,17 @@ static int ext2fs_read_inode
>  	printf ("ext2fs read inode blkno %d blkoff %d\n", blkno, blkoff);
>  #endif
>  	/* Read the inode.  */
> +#ifdef CFG_EXT2_SUPPORT_DYNAMIC_REV
> +	status = ext2fs_devread (((__le32_to_cpu (blkgrp.inode_table_id) +
> +				   blkno) << LOG2_EXT2_BLOCK_SIZE (data)),
> +				 ext2_inode_size * blkoff,
> +				 sizeof (struct ext2_inode), (char *)
> inode);
^^^^^^^^^
> +#else
>  	status = ext2fs_devread (((__le32_to_cpu (blkgrp.inode_table_id) +
>  				   blkno) << LOG2_EXT2_BLOCK_SIZE (data)),
>  				 sizeof (struct ext2_inode) * blkoff,
>  				 sizeof (struct ext2_inode), (char *)
> inode);
^^^^^^^^^
> +#endif
>  	if (status == 0) {
>  		return (0);
>  	}
> @@ -243,8 +266,13 @@ void ext2fs_free_node (ext2fs_node_t node,
> ext2fs_node_t currroot) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

etc.

Your patch is corrupted because your mailer wrapped long lines.

Please fix your mailer and repost (with a nice commit message,
please).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In a survey taken several years ago, all  incoming  freshmen  at  MIT
were  asked  if  they  expected  to graduate in the top half of their
class. Ninety-seven percent responded that they did.

      parent reply	other threads:[~2008-08-18 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-29  8:48 [U-Boot-Users] PATCH: Update U-Boot EXT2 Filesystem to support dynamic inode size and optimize ext2 read function to fasten read speed! Ryan CHEN
2008-07-29 20:10 ` Scott Wood
2008-07-30  1:37   ` Ryan CHEN
2008-07-29 23:16 ` Wolfgang Denk
2008-07-30  2:00   ` Ryan CHEN
2008-08-01  9:44     ` Detlev Zundel
2008-08-18 21:58     ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080818215853.C0D1824899@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox