From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/6] i.MX31: Add reset_timer() and modify get_timer_masked().
Date: Tue, 19 Aug 2008 11:00:17 +0200 [thread overview]
Message-ID: <20080819090017.GC9094@game.jcrosoft.org> (raw)
In-Reply-To: <59b21cf20808190155x50a7b688g901a4061e06cb8a3@mail.gmail.com>
On 10:55 Tue 19 Aug , Magnus Lilja wrote:
> Hi
>
> 2008/8/18 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
> > On 11:30 Mon 18 Aug , Magnus Lilja wrote:
> >> This patch adds the reset_timer() function (needed by nand_base.c) and
> >> modifies the get_timer_masked() to work in the same way as the omap24xx
> >> function.
> >>
> >> Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com>
> >> ---
> >> cpu/arm1136/mx31/interrupts.c | 22 ++++++++++++++++++----
> >> 1 files changed, 18 insertions(+), 4 deletions(-)
> > Could you add the comment like omap24xx?
>
> Hmm, I probably could but I'm not sure that I understand what you mean
> here. Shall I add a comment to the patch description or to the code
> itself? The patch description mentions omap24xx already.
Just comment like done in the omap24xx interreupt
other the patch is OK
Best Regards,
J.
next prev parent reply other threads:[~2008-08-19 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 9:30 [U-Boot] [PATCH v2 0/6] i.MX31: Add NAND support and new PDK board Magnus Lilja
2008-08-18 9:30 ` [U-Boot] [PATCH v2 1/6] i.MX31: Add NFC_BASE_ADDR definition Magnus Lilja
2008-08-18 9:30 ` [U-Boot] [PATCH v2 2/6] i.MX31: Add reset_timer() and modify get_timer_masked() Magnus Lilja
2008-08-18 9:30 ` [U-Boot] [PATCH v2 3/6] i.MX31: Add i.MX31 NAND Flash Controller driver Magnus Lilja
2008-08-18 9:30 ` [U-Boot] [PATCH v2 4/6] i.MX31: Add NAND support in the i.MX31 Litekit config file Magnus Lilja
2008-08-18 9:30 ` [U-Boot] [PATCH v2 5/6] i.MX31: Make the SPI bus and chip select configurable for MC13783 Magnus Lilja
2008-08-18 9:30 ` [U-Boot] [PATCH v2 6/6] i.MX31: Add basic support for Freescale's i.MX31 PDK board Magnus Lilja
2008-08-19 9:01 ` [U-Boot] [PATCH v2 5/6] i.MX31: Make the SPI bus and chip select configurable for MC13783 Jean-Christophe PLAGNIOL-VILLARD
2008-08-19 11:26 ` Magnus Lilja
2008-08-18 21:02 ` [U-Boot] [PATCH v2 3/6] i.MX31: Add i.MX31 NAND Flash Controller driver Scott Wood
2008-08-18 21:40 ` [U-Boot] [PATCH v2 2/6] i.MX31: Add reset_timer() and modify get_timer_masked() Jean-Christophe PLAGNIOL-VILLARD
2008-08-19 8:55 ` Magnus Lilja
2008-08-19 9:00 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-08-18 21:36 ` [U-Boot] [PATCH v2 1/6] i.MX31: Add NFC_BASE_ADDR definition Jean-Christophe PLAGNIOL-VILLARD
2008-08-19 8:53 ` Magnus Lilja
2008-08-27 22:46 ` [U-Boot] [PATCH v2 0/6] i.MX31: Add NAND support and new PDK board Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 8:53 ` Magnus Lilja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819090017.GC9094@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox