public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [POWERPC] TQM8272: Fix compiling error for the TQM8272 board.
Date: Wed, 27 Aug 2008 13:59:10 +0200	[thread overview]
Message-ID: <200808271359.10694.sr@denx.de> (raw)
In-Reply-To: <48B53BD7.2040301@denx.de>

On Wednesday 27 August 2008, Heiko Schocher wrote:
> > You have integrated this NAND driver into the tqm8272.c source file. I
> > suggest you move this at some time into the drivers/mtd/nand directory.
> > Is it a
>
> Why? That are just the boardspecific routines, not a complete NAND driver!

It looks like a complete NAND driver to me. I'm referring to the CPU- / 
board-specific part of it. The part in:

#if defined(CONFIG_CMD_NAND)

#include <nand.h>
#include <linux/mtd/mtd.h>

static u8 hwctl = 0;
...

is what I'm talking about.

> > TQM8272 specific driver? Or is this MPC8xxx specific? From the name of
> > the functions (upm_xxx) this seems to match the already available driver
> > under:
> >
> > drivers/mtd/nand/fsl_upm.c
> >
> > Is it possible that you can use this common FSL-UPM version?
>
> Maybe this is posible, but without the Hardware to try this new
> version, I dont like to make such a "big" change ...

Understood. But at least extracting this driver into a separate file would 
help to identify this code as NAND driver. Just my 0.02 $.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-08-27 11:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27 11:08 [U-Boot] [POWERPC] TQM8272: Fix compiling error for the TQM8272 board Heiko Schocher
2008-08-27 11:13 ` Stefan Roese
2008-08-27 11:34   ` Heiko Schocher
2008-08-27 11:59     ` Stefan Roese [this message]
2008-08-27 18:37       ` [U-Boot] [PATCH v2] " Heiko Schocher
2008-08-27 20:10         ` Scott Wood
2008-08-28 11:48           ` [U-Boot] [PATCH v3] " Heiko Schocher
2008-09-06 21:31             ` Wolfgang Denk
2008-08-28 11:50           ` [U-Boot] [PATCH][POWERPC] TQM8272: move NAND part in seperate File Heiko Schocher
2008-09-06 21:32             ` Wolfgang Denk
2008-09-06 20:54         ` [U-Boot] [PATCH v2] [POWERPC] TQM8272: Fix compiling error for the TQM8272 board Wolfgang Denk
2008-08-27 20:09 ` [U-Boot] " Scott Wood
2008-08-28  3:35   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808271359.10694.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox