public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/1] ppc4xx: fix UIC external_interrupt hang on UIC0
@ 2008-08-28 23:03 Victor Gallardo
  2008-08-29  8:15 ` Stefan Roese
  0 siblings, 1 reply; 2+ messages in thread
From: Victor Gallardo @ 2008-08-28 23:03 UTC (permalink / raw)
  To: u-boot

This patch fixes a UIC external_interrupt hang if critical or non-critical
interrupt is set at the same time as a normal interrupt is set on UIC0.

Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
---
 cpu/ppc4xx/uic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/ppc4xx/uic.c b/cpu/ppc4xx/uic.c
index 7944c6c..a95d1cb 100644
--- a/cpu/ppc4xx/uic.c
+++ b/cpu/ppc4xx/uic.c
@@ -129,11 +129,11 @@ void external_interrupt(struct pt_regs *regs)
 		uic_interrupt(UIC3_DCR_BASE, 96);
 #endif
 
+	mtdcr(uic0sr, (uic_msr & UICB0_ALL));
+
 	if (uic_msr & ~(UICB0_ALL))
 		uic_interrupt(UIC0_DCR_BASE, 0);
 
-	mtdcr(uic0sr, uic_msr);
-
 	return;
 }
 
-- 
1.5.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH 1/1] ppc4xx: fix UIC external_interrupt hang on UIC0
  2008-08-28 23:03 [U-Boot] [PATCH 1/1] ppc4xx: fix UIC external_interrupt hang on UIC0 Victor Gallardo
@ 2008-08-29  8:15 ` Stefan Roese
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2008-08-29  8:15 UTC (permalink / raw)
  To: u-boot

On Friday 29 August 2008, Victor Gallardo wrote:
> This patch fixes a UIC external_interrupt hang if critical or non-critical
> interrupt is set at the same time as a normal interrupt is set on UIC0.

Applied to u-boot-ppc4xx. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-29  8:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-28 23:03 [U-Boot] [PATCH 1/1] ppc4xx: fix UIC external_interrupt hang on UIC0 Victor Gallardo
2008-08-29  8:15 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox