public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] device: clone device on register
Date: Mon, 1 Sep 2008 21:50:26 +0200	[thread overview]
Message-ID: <20080901195026.GA316@game.jcrosoft.org> (raw)
In-Reply-To: <20080901181545.0d9eb7bd@hskinnemo-gx745.norway.atmel.com>

On 18:15 Mon 01 Sep     , Haavard Skinnemoen wrote:
> Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > > to prevent that the pointer will not be use for an other register
> > > 
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>  
> > 
> > Er. What? If a device is registered multiple times, that sounds like
> > something which should be fixed, not papered over like this...
> 
> I take that back. I didn't realize how much of a f***ing trainwreck the
> device system is...apparently the callers expect device_register() to
> clone the device, but this fact was hidden well within the old list
> implementation. Your patches makes this much more apparent, which is
> obviously good.
> 
> Oh, and your patch fixes the breakage I was seeing on avr32. Thanks.

I've plan to cleanup this part during next release.

and redesign console management to simplify it and reduce its code.

I'm currently designing a generic bus/device/driver mecanism that will
simplify the implementation without increase the size.

I'll send a announce about it

Best Regards,
J.

  reply	other threads:[~2008-09-01 19:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 11:40 [U-Boot] [BUG] common/console.c Heiko Schocher
2008-09-01 15:11 ` [U-Boot] [PATCH 1/1] device: clone device on register Jean-Christophe PLAGNIOL-VILLARD
2008-09-01 15:48   ` Haavard Skinnemoen
2008-09-01 16:15     ` Haavard Skinnemoen
2008-09-01 19:50       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-09-02  8:00         ` Haavard Skinnemoen
2008-09-01 22:55     ` Wolfgang Denk
2008-09-01 23:02       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080901195026.GA316@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox