public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] device: clone device on register
Date: Tue, 02 Sep 2008 01:02:07 +0200	[thread overview]
Message-ID: <20080901230207.AE7AA242FF@gemini.denx.de> (raw)
In-Reply-To: <20080901225552.70D16242FF@gemini.denx.de>

I wrote:

> > > to prevent that the pointer will not be use for an other register
> > > 
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > 
> > Er. What? If a device is registered multiple times, that sounds like
> > something which should be fixed, not papered over like this...
> > 
> > Btw, while I'm all for getting rid of common/lists.c, your cryptic
> > one-line commit message is a shooting offense to anyone who tries to
> > understand WTF is going on...
> 
> I agree with Haavard on both accounts.
> 
> Can you please look into this again? Thanks

OK, I learned that item (1) was actually a non-issue.

But can we please use a commit message that can be understood?
I cannot parse the current one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe, they said, depended for its operation on the balance of
four forces which they identified as charm,  persuasion,  uncertainty
and bloody-mindedness.      -- Terry Pratchett, "The Light Fantastic"

      reply	other threads:[~2008-09-01 23:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 11:40 [U-Boot] [BUG] common/console.c Heiko Schocher
2008-09-01 15:11 ` [U-Boot] [PATCH 1/1] device: clone device on register Jean-Christophe PLAGNIOL-VILLARD
2008-09-01 15:48   ` Haavard Skinnemoen
2008-09-01 16:15     ` Haavard Skinnemoen
2008-09-01 19:50       ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-02  8:00         ` Haavard Skinnemoen
2008-09-01 22:55     ` Wolfgang Denk
2008-09-01 23:02       ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080901230207.AE7AA242FF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox