public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board
@ 2008-09-03 15:15 Matthias Fuchs
  2008-09-03 20:58 ` Wolfgang Denk
  0 siblings, 1 reply; 3+ messages in thread
From: Matthias Fuchs @ 2008-09-03 15:15 UTC (permalink / raw)
  To: u-boot

This patch adds initdram() to DASA_SIM boards that has been
removed accidentally by a previous commit.

Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
---
 board/esd/dasa_sim/dasa_sim.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/board/esd/dasa_sim/dasa_sim.c b/board/esd/dasa_sim/dasa_sim.c
index def0354..4cc3a2f 100644
--- a/board/esd/dasa_sim/dasa_sim.c
+++ b/board/esd/dasa_sim/dasa_sim.c
@@ -202,3 +202,8 @@ int checkboard (void)
 
 	return 0;
 }
+
+phys_size_t initdram (int board_type)
+{
+	return (16 * 1024 * 1024);
+}
-- 
1.5.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board
  2008-09-03 15:15 [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board Matthias Fuchs
@ 2008-09-03 20:58 ` Wolfgang Denk
  2008-09-04 10:36   ` Matthias Fuchs
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Denk @ 2008-09-03 20:58 UTC (permalink / raw)
  To: u-boot

Dear Matthias Fuchs,

In message <200809031715.45250.matthias.fuchs@esd-electronics.com> you wrote:
> This patch adds initdram() to DASA_SIM boards that has been
> removed accidentally by a previous commit.
> 
> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> ---
>  board/esd/dasa_sim/dasa_sim.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/board/esd/dasa_sim/dasa_sim.c b/board/esd/dasa_sim/dasa_sim.c
> index def0354..4cc3a2f 100644
> --- a/board/esd/dasa_sim/dasa_sim.c
> +++ b/board/esd/dasa_sim/dasa_sim.c
> @@ -202,3 +202,8 @@ int checkboard (void)
>  
>  	return 0;
>  }
> +
> +phys_size_t initdram (int board_type)
> +{
> +	return (16 * 1024 * 1024);
> +}

We should really get rid of hard-coded memory sizes and auto-size all
boards.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Change is the essential process of all existence.
	-- Spock, "Let That Be Your Last Battlefield",
	   stardate 5730.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board
  2008-09-03 20:58 ` Wolfgang Denk
@ 2008-09-04 10:36   ` Matthias Fuchs
  0 siblings, 0 replies; 3+ messages in thread
From: Matthias Fuchs @ 2008-09-04 10:36 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

you are right. But currently I do not have any suitable IOP480 based
hardware on my desk to test bigger changes.

Matthias

On Wednesday 03 September 2008 22:58, Wolfgang Denk wrote:
> Dear Matthias Fuchs,
> 
> In message <200809031715.45250.matthias.fuchs@esd-electronics.com> you wrote:
> > This patch adds initdram() to DASA_SIM boards that has been
> > removed accidentally by a previous commit.
> > 
> > Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> > ---
> >  board/esd/dasa_sim/dasa_sim.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/board/esd/dasa_sim/dasa_sim.c b/board/esd/dasa_sim/dasa_sim.c
> > index def0354..4cc3a2f 100644
> > --- a/board/esd/dasa_sim/dasa_sim.c
> > +++ b/board/esd/dasa_sim/dasa_sim.c
> > @@ -202,3 +202,8 @@ int checkboard (void)
> >  
> >  	return 0;
> >  }
> > +
> > +phys_size_t initdram (int board_type)
> > +{
> > +	return (16 * 1024 * 1024);
> > +}
> 
> We should really get rid of hard-coded memory sizes and auto-size all
> boards.
> 
> Best regards,
> 
> Wolfgang Denk
> 

-- 
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-09-04 10:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-03 15:15 [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board Matthias Fuchs
2008-09-03 20:58 ` Wolfgang Denk
2008-09-04 10:36   ` Matthias Fuchs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox