public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board
Date: Wed, 03 Sep 2008 22:58:43 +0200	[thread overview]
Message-ID: <20080903205843.1CF08248A0@gemini.denx.de> (raw)
In-Reply-To: <200809031715.45250.matthias.fuchs@esd-electronics.com>

Dear Matthias Fuchs,

In message <200809031715.45250.matthias.fuchs@esd-electronics.com> you wrote:
> This patch adds initdram() to DASA_SIM boards that has been
> removed accidentally by a previous commit.
> 
> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> ---
>  board/esd/dasa_sim/dasa_sim.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/board/esd/dasa_sim/dasa_sim.c b/board/esd/dasa_sim/dasa_sim.c
> index def0354..4cc3a2f 100644
> --- a/board/esd/dasa_sim/dasa_sim.c
> +++ b/board/esd/dasa_sim/dasa_sim.c
> @@ -202,3 +202,8 @@ int checkboard (void)
>  
>  	return 0;
>  }
> +
> +phys_size_t initdram (int board_type)
> +{
> +	return (16 * 1024 * 1024);
> +}

We should really get rid of hard-coded memory sizes and auto-size all
boards.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Change is the essential process of all existence.
	-- Spock, "Let That Be Your Last Battlefield",
	   stardate 5730.2

  reply	other threads:[~2008-09-03 20:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03 15:15 [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board Matthias Fuchs
2008-09-03 20:58 ` Wolfgang Denk [this message]
2008-09-04 10:36   ` Matthias Fuchs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080903205843.1CF08248A0@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox