public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] unassigned-patches/25: [PATCH] USB EHCI: reset root	hub
Date: Thu, 4 Sep 2008 10:44:26 +0200	[thread overview]
Message-ID: <20080904084426.GA16085@lisa> (raw)
In-Reply-To: <20080815134502.4011D28114@theia.denx.de>

Dear Yuri,

On Fri, Aug 15, 2008 at 03:45:02PM +0200, u-boot at bugs.denx.de wrote:

>  Some of multi-function USB controllers (e.g. ISP1562) allow root hub
> resetting only via EHCI registers. So, this patch adds the corresponding
> kind of reset to OHCI's hc_reset() if the newly introduced CONFIG_PCI_EHCI_DEVNO
> option is set (e.g. for Socrates board).
> 
> Signed-off-by: Yuri Tikhonov <yur@emcraft.com>
> 
> ---
> Added to GNATS database as unassigned-patches/25
> >Responsible:    patch-coord
> >Message-Id:     <1218807733-26929-3-git-send-email-dzu@denx.de>
> >In-Reply-To:    <1218807733-26929-2-git-send-email-dzu@denx.de>
> >References:     <1218807733-26929-1-git-send-email-dzu@denx.de> <1218807733-26929-2-git-send-email-dzu@denx.de>
> >Patch-Date:     Fri Aug 15 15:42:10 +0200 2008
> ---
>  drivers/usb/usb_ohci.c     |   31 +++++++++++++++++++++++++++++++
>  drivers/usb/usb_ohci.h     |    3 +++
>  include/configs/socrates.h |    1 +
>  3 files changed, 35 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/usb_ohci.c b/drivers/usb/usb_ohci.c
> index fd60edb..0f5bd06 100644
> --- a/drivers/usb/usb_ohci.c
> +++ b/drivers/usb/usb_ohci.c
> @@ -1571,11 +1571,42 @@ int submit_int_msg(struct usb_device *dev, unsigned long pipe, void *buffer,
>  
>  static int hc_reset (ohci_t *ohci)
>  {
> +#ifdef CONFIG_PCI_EHCI_DEVNO
> +	pci_dev_t pdev;
> +	struct pci_device_id ehci_pci_ids[] = {
> +		{0x1131, 0x1562},	/* Philips 1562 PCI EHCI module ids */
> +		{0, 0}
> +	};

Please move this out of the function, preferrably next to the OHCI
device ids.

Thanks!

Best regards

Markus

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de")

  parent reply	other threads:[~2008-09-04  8:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1218807733-26929-1-git-send-email-dzu@denx.de>
2008-08-15 13:45 ` [U-Boot] unassigned-patches/24: [PATCH] PHY: Add support for the M88E1121R Marvell chip u-boot at bugs.denx.de
2008-09-01 15:39   ` Detlev Zundel
2008-09-01 22:00     ` Ben Warren
2008-09-01 22:48       ` Detlev Zundel
2008-09-02  0:34         ` Ben Warren
2008-09-02  8:11           ` Detlev Zundel
     [not found] ` <1218807733-26929-2-git-send-email-dzu@denx.de>
2008-08-15 13:45   ` [U-Boot] unassigned-patches/23: [PATCH] RX 8025 RTC: analyze 12/24-hour mode flag in rtc_get() u-boot at bugs.denx.de
2008-09-01 15:41     ` Detlev Zundel
     [not found]   ` <1218807733-26929-3-git-send-email-dzu@denx.de>
     [not found]     ` <1218807733-26929-4-git-send-email-dzu@denx.de>
2008-08-15 13:45       ` [U-Boot] unassigned-patches/22: [PATCH] Removed hardcoded MxMR loop value from upmconfig() for MPC85xx u-boot at bugs.denx.de
     [not found]       ` <1218807733-26929-5-git-send-email-dzu@denx.de>
2008-08-15 13:45         ` [U-Boot] unassigned-patches/27: [PATCH] 85xx: Socrates: Major code update u-boot at bugs.denx.de
     [not found]         ` <1218807733-26929-6-git-send-email-dzu@denx.de>
2008-08-15 13:45           ` [U-Boot] unassigned-patches/26: [PATCH] 85xx: socrates: Enable Lime support u-boot at bugs.denx.de
2008-08-15 13:45     ` [U-Boot] unassigned-patches/25: [PATCH] USB EHCI: reset root hub u-boot at bugs.denx.de
2008-09-01 15:41       ` Detlev Zundel
2008-09-01 17:33         ` Markus Klotzbücher
2008-09-04  8:44       ` Markus Klotzbücher [this message]
2008-09-04  9:19         ` [U-Boot] [PATCH v2] " Detlev Zundel
2008-09-04  9:44           ` Markus Klotzbücher
2008-09-05 23:25           ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080904084426.GA16085@lisa \
    --to=mk@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox