public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board
Date: Thu, 4 Sep 2008 12:36:08 +0200	[thread overview]
Message-ID: <200809041236.08950.matthias.fuchs@esd-electronics.com> (raw)
In-Reply-To: <20080903205843.1CF08248A0@gemini.denx.de>

Hi Wolfgang,

you are right. But currently I do not have any suitable IOP480 based
hardware on my desk to test bigger changes.

Matthias

On Wednesday 03 September 2008 22:58, Wolfgang Denk wrote:
> Dear Matthias Fuchs,
> 
> In message <200809031715.45250.matthias.fuchs@esd-electronics.com> you wrote:
> > This patch adds initdram() to DASA_SIM boards that has been
> > removed accidentally by a previous commit.
> > 
> > Signed-off-by: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> > ---
> >  board/esd/dasa_sim/dasa_sim.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/board/esd/dasa_sim/dasa_sim.c b/board/esd/dasa_sim/dasa_sim.c
> > index def0354..4cc3a2f 100644
> > --- a/board/esd/dasa_sim/dasa_sim.c
> > +++ b/board/esd/dasa_sim/dasa_sim.c
> > @@ -202,3 +202,8 @@ int checkboard (void)
> >  
> >  	return 0;
> >  }
> > +
> > +phys_size_t initdram (int board_type)
> > +{
> > +	return (16 * 1024 * 1024);
> > +}
> 
> We should really get rid of hard-coded memory sizes and auto-size all
> boards.
> 
> Best regards,
> 
> Wolfgang Denk
> 

-- 
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------

      reply	other threads:[~2008-09-04 10:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03 15:15 [U-Boot] [PATCH] ppx4xx: Fix broken DASA_SIM board Matthias Fuchs
2008-09-03 20:58 ` Wolfgang Denk
2008-09-04 10:36   ` Matthias Fuchs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809041236.08950.matthias.fuchs@esd-electronics.com \
    --to=matthias.fuchs@esd-electronics.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox