public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] CFG_64BIT_xxx and friends
Date: Sun, 07 Sep 2008 01:12:41 +0200	[thread overview]
Message-ID: <20080906231241.25260248BB@gemini.denx.de> (raw)
In-Reply-To: <200809041609.26474.matthias.fuchs@esd-electronics.com>

Dear Matthias,

in message <200809041609.26474.matthias.fuchs@esd-electronics.com> you wrote:
> 
> after testing the recent U-Boot code on a couple of 405EP boards I noticed,
> that the memsize in the output of the "bdinfo" command is always 0x00000000.
> 
> This is caused by using 64 types and format directives in printf that only 
> work when CFG_64BIT_VSPRINTF is defined.

Yeah, that's one more of these ugly bugs.

> So what's the best way to fix this?
> Here are four solutions. My favorite is no. 2.
> 
> 1) Define CFG_64BIT_STRTOUL for all effected board. 
> Currently all 405 boards have memsize output as 0 in bdinfo.
> 
> 2) Define CFG_64BIT_VSPRINTF and CFG_64BIT_STRTOUL for all 4xx boards in
> include/ppc4xx.h:
...
> 3) Generally define CFG_64BIT_VSPRINTF and CFG_64BIT_STRTOUL for all boards.
> 
> 4) Use an (ugly) workaround in common/cmd_bdinfo.c:

I vote for # 5:

5) Delete al references to CFG_64BIT_VSPRINTF and CFG_64BIT_STRTOUL
and unconditionally enable it for all boards.

Any takers to submit a patch?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One day," said a dull voice from down below, "I'm going to  be  back
in  form again and you're going to be very sorry you said that. For a
very long time. I might even go so far as to make even more Time just
for you to be sorry in."              - Terry Pratchett, _Small Gods_

  reply	other threads:[~2008-09-06 23:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 14:09 [U-Boot] CFG_64BIT_xxx and friends Matthias Fuchs
2008-09-06 23:12 ` Wolfgang Denk [this message]
2008-09-06 23:05   ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-06 23:37     ` Wolfgang Denk
2008-09-08  7:43       ` Stefan Roese
2008-09-08 11:00         ` Haavard Skinnemoen
2008-09-08 11:27           ` Matthias Fuchs
2008-09-08 11:54             ` Haavard Skinnemoen
2008-09-08 12:23               ` Haavard Skinnemoen
2008-09-09  1:58                 ` Jerry Van Baren
2008-09-09  7:11                   ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080906231241.25260248BB@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox