[U-Boot] [PATCH] Remove gap fill in srec object

Ricardo Ribalda Delgado
2008-09-07T21:10:46Z

Hello Wolfgang

>> Srec files do need gap fill: The load address is specified in the file.
>
> I guess you mean "do *not* need gap fill" ?
You are completely right.

>
>> On ppc, a common object consist on u-boot on the begining of the memory
>> and a jump and tlb setup on the last part of the memory (0xfffffffe).
>
> This is not correct. The U-Boot image does not occupy any low memory
> - low memory is reserved for RAM, while the U-Boot image is stored in
> ROM. ROM is typically mapped in high memory, often close to the end
> of the physical address space.
>
This is not true 100%. I have a design with this memory map:

0-128 MB -> RAM

128-192 MB-> ROM

Last 32 KB BRAM (initialized ram)

It is not a typical design, but it is possible. In this case u-boot
will be located in the last bram and in the rom, with gap fill U-biit
srec will be huge.
Again: It is not a typical design!

> I think your patch makes sense and could be applied, but the commit
> message is too incorrect. Please fix this and resubmit.

OK, I think it have no sense to discuss the commit message. New patch
is in your inbox

Best regards

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Those who hate and fight must stop themselves -- otherwise it is not
> stopped.
> -- Spock, "Day of the Dove", stardate unknown
>

--
Ricardo Ribalda