[U-Boot] [PATCH] ppc440: New board: Avnet Virtex5 FXT Evaluation

Michal Simek
2008-08-25T13:36:40Z

Hi,

> Hello Again
>
> Michal, on xilinx boards almost everything can be handled by
> edk+xparameters, but in other boards this is not true. Last month I
> was working on a board that had a weird watchdog and a memory that
> needed to handled by a propietary IP, in this case, we need a board
> directory because the generic board should not support it: otherwise
> the generic board will have many defiles like #ifdef
> STRANGE_BOARD_USED_ONCE :)

I know that I wrote that not every possible choices are covered but you wrote
that you use proprietary IP.
Yes, we will need board directory for proprietary solution. Look at my first
email I wrote about. Of course if you do your project you should create some
directories only for you.
But I think we don't need special folder for reference design and board.

Your STRANGE_BOARD_USED_ONCE choice is due to you use something strange which
should not go to mainline U-BOOT. I don't like strange things. If is something
strange you have to find out why. Just writing strange is more stranger for
others which will read your code.

Please add more choices which you need in your config.

Memory,
flash,
iic,
spi,
watchdog,
dtc,
maybe gpio - but this is not important
dcr reading,
systemace,
ethernet controllers,
uarts

I see maybe 20 ifdef choices not more right now. Please correct me if I am wrong.

Michal

> Waiting for your comments.
>
>
>