public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [POWERPC] [BUG?] ppc4xx: PCIX0_STS versus PCIX0_STATUS in 4xx_pci.c
@ 2008-09-05 21:56 carolyn.j.smith at tektronix.com
  2008-09-08 15:09 ` Stefan Roese
  0 siblings, 1 reply; 2+ messages in thread
From: carolyn.j.smith at tektronix.com @ 2008-09-05 21:56 UTC (permalink / raw)
  To: u-boot

Hello everyone,

In the pci_440_init function in cpu/ppc4xx/4xx_pci.c, shouldn't this

out32r( PCIX0_STS, in32r( PCIX0_STS ) & ~0x0000fff8 );

really be this?

out32r( PCIX0_STATUS, in32r( PCIX0_STATUS ) & ~0x0000fff8 );

Thanks,
Carolyn

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot] [POWERPC] [BUG?] ppc4xx: PCIX0_STS versus PCIX0_STATUS in 4xx_pci.c
  2008-09-05 21:56 [U-Boot] [POWERPC] [BUG?] ppc4xx: PCIX0_STS versus PCIX0_STATUS in 4xx_pci.c carolyn.j.smith at tektronix.com
@ 2008-09-08 15:09 ` Stefan Roese
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2008-09-08 15:09 UTC (permalink / raw)
  To: u-boot

Carolyn,

On Friday 05 September 2008, carolyn.j.smith at tektronix.com wrote:
> In the pci_440_init function in cpu/ppc4xx/4xx_pci.c, shouldn't this
>
> out32r( PCIX0_STS, in32r( PCIX0_STS ) & ~0x0000fff8 );
>
> really be this?
>
> out32r( PCIX0_STATUS, in32r( PCIX0_STATUS ) & ~0x0000fff8 );

Could you please explain, why you think this is the case? Are you seeing 
problems with this code? And are they solved when you use the other register 
instead?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-08 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-05 21:56 [U-Boot] [POWERPC] [BUG?] ppc4xx: PCIX0_STS versus PCIX0_STATUS in 4xx_pci.c carolyn.j.smith at tektronix.com
2008-09-08 15:09 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox