public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Update i386 code (sc520_cdp)
Date: Tue, 09 Sep 2008 11:49:56 +0200	[thread overview]
Message-ID: <20080909094956.26EE52489D@gemini.denx.de> (raw)
In-Reply-To: <1220735322.6322.8.camel@devel>

Dear Graeme Russ,

In message <1220735322.6322.8.camel@devel> you wrote:
> Attempt to bring i386 / sc520 inline with master

To make some progress, I manually fixed the wrapped lines (you owe me
a beer for that) and applied most of your patch.

I omitted this part though:

> diff --git a/include/image.h b/include/image.h
> index 9be806e..e095a32 100644
> --- a/include/image.h
> +++ b/include/image.h
> @@ -40,7 +40,7 @@
>  #include <lmb.h>
>  #include <linux/string.h>
>  #include <asm/u-boot.h>
> -
> +#include <asm/string.h>
>  #else

Including <asm/string.h> seems bogus to me as this is already done in
<linux/string.h> which is  included  just  two  lines  above.  Please
check.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: kernel trap (ignored)

  reply	other threads:[~2008-09-09  9:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-06 13:34 [U-Boot] [PATCH 1/2] Update i386 code (sc520_cdp) Graeme Russ
2008-09-06 15:42 ` Wolfgang Denk
2008-09-06 21:08   ` Graeme Russ
2008-09-09  9:49     ` Wolfgang Denk [this message]
2008-09-09 11:08       ` Graeme Russ
2008-09-09 21:32         ` Wolfgang Denk
2008-09-10 11:54           ` Graeme Russ
2008-09-10 14:46             ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-10 20:51               ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2008-09-06 21:55 Graeme Russ
2008-09-06 23:35 ` Wolfgang Denk
2008-09-07  0:01   ` Graeme Russ
2008-09-07  0:05     ` Wolfgang Denk
2008-09-08 12:28     ` JerryVanBaren
2008-09-07  0:06 Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080909094956.26EE52489D@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox