public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Fix dev_print for when it is called from	usb_stor_info (usb storage command)
Date: Tue, 9 Sep 2008 15:50:37 +0200	[thread overview]
Message-ID: <20080909135037.GA5659@lisa> (raw)
In-Reply-To: <200809091013.47319.nicolas.lebedenco@tasksistemas.com.br>

Dear Nicholas,

On Tue, Sep 09, 2008 at 10:13:47AM -0300, N?colas Carneiro Lebedenco wrote:
> 
> Here it goes. I'm not sure if I got you right. Is it ok, now ?

Almost. 

> Signed-off-by: Nicolas Lebedenco <nicolas.lebedenco@tasksistemas.com.br>

This line should go _after_ the Changelog entry...

> It fixes the output of the command usb storage. It was printing  
> "Device 0: not available" because the IF_TYPE_USB was not included into the 
> switch statement.

and before the actual patch (namely here!)

> --- u-boot-1.3.4.original/disk/part.c	2008-08-12 11:08:38.000000000 -0300
> +++ u-boot-1.3.4/disk/part.c	2008-09-04 14:48:55.000000000 -0300
> @@ -124,6 +124,12 @@ void dev_print (block_dev_desc_t *dev_de
>  			dev_desc->revision,
>  			dev_desc->product);
>  		break;
> +	case IF_TYPE_USB:
> +		printf ("Vendor: %s Rev: %s Prod: %s\n",
> +			dev_desc->vendor,
> +			dev_desc->revision,
> +			dev_desc->product);
> +		break;
>  	case IF_TYPE_UNKNOWN:
>  	default:
>  		puts ("not available\n");

Sorry for beeing so pedantic, but could you fix this and resend once
more without context?  This is so we can use git-am to apply your
patch!

Obrigado!

Markus

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de")

  reply	other threads:[~2008-09-09 13:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04 18:35 [U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command) Nícolas Carneiro Lebedenco
2008-09-09  9:41 ` Wolfgang Denk
2008-09-09 13:13   ` Nícolas Carneiro Lebedenco
2008-09-09 13:50     ` Markus Klotzbücher [this message]
2008-09-09 14:02       ` Wolfgang Denk
2008-09-09 14:05     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080909135037.GA5659@lisa \
    --to=mk@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox