[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

[Nícolas Carneiro Lebedenco]

Hello people,

here is a quick fix for the output of the command usb storage. It was printing  
"Device 0: not available" because the IF_TYPE_USB was not included into the 
switch statement.

--- u-boot-1.3.4.original/disk/part.c	2008-08-12 11:08:38.000000000 -0300
+++ u-boot-1.3.4/disk/part.c	2008-09-04 14:48:55.000000000 -0300
@@ -124,6 +124,12 @@ void dev_print (block_dev_desc_t *dev_de
 			dev_desc->revision,
 			dev_desc->product);
 		break;
+	case IF_TYPE_USB:
+		printf ("Vendor: %s Rev: %s Prod: %s\n",
+			dev_desc->vendor,
+			dev_desc->revision,
+			dev_desc->product);
+		break;
 	case IF_TYPE_UNKNOWN:
 	default:
 		puts ("not available\n");
--

Now, for example, with my usb kingston datatraveller, it correctly prints:

U-Boot> usb storage
  Device 0: Vendor: Kingston Rev: 1.00 Prod: DataTraveler 2.0
            Type: Removable Hard Disk
            Capacity: 1956.5 MB = 1.9 GB (4006912 x 512) 

Regards,

N?colas

[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

[Wolfgang Denk]

Dear =?iso-8859-1?q?N=EDcolas_Carneiro_Lebedenco?=,

In message <200809041535.46614.nicolas.lebedenco@tasksistemas.com.br> you wrote:
> 
> here is a quick fix for the output of the command usb storage. It was print=
> ing  =
> 
> "Device 0: not available" because the IF_TYPE_USB was not included into the =
> 
> switch statement.

Thanks - can you please add your Signed-off-by: line and repost?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If only God would give me some clear sign! Like making a large  depo-
sit in my name at a Swiss Bank.                         - Woody Allen

[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

[Nícolas Carneiro Lebedenco]

Em Tue, 09 de September de 2008 06:41:25 Wolfgang Denk escreveu:
> Dear =?iso-8859-1?q?N=EDcolas_Carneiro_Lebedenco?=,
>
> In message <200809041535.46614.nicolas.lebedenco@tasksistemas.com.br> you 
wrote:
> > here is a quick fix for the output of the command usb storage. It was
> > print= ing  =
> >
> > "Device 0: not available" because the IF_TYPE_USB was not included into
> > the =
> >
> > switch statement.
>
> Thanks - can you please add your Signed-off-by: line and repost?
>
> Best regards,
>
> Wolfgang Denk

Here it goes. I'm not sure if I got you right. Is it ok, now ?

Regards,

N?colas

Signed-off-by: Nicolas Lebedenco <nicolas.lebedenco@tasksistemas.com.br>
--
It fixes the output of the command usb storage. It was printing  
"Device 0: not available" because the IF_TYPE_USB was not included into the 
switch statement.

--- u-boot-1.3.4.original/disk/part.c	2008-08-12 11:08:38.000000000 -0300
+++ u-boot-1.3.4/disk/part.c	2008-09-04 14:48:55.000000000 -0300
@@ -124,6 +124,12 @@ void dev_print (block_dev_desc_t *dev_de
 			dev_desc->revision,
 			dev_desc->product);
 		break;
+	case IF_TYPE_USB:
+		printf ("Vendor: %s Rev: %s Prod: %s\n",
+			dev_desc->vendor,
+			dev_desc->revision,
+			dev_desc->product);
+		break;
 	case IF_TYPE_UNKNOWN:
 	default:
 		puts ("not available\n");

[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

[Markus Klotzbücher]

Dear Nicholas,

On Tue, Sep 09, 2008 at 10:13:47AM -0300, N?colas Carneiro Lebedenco wrote:
> 
> Here it goes. I'm not sure if I got you right. Is it ok, now ?

Almost. 

> Signed-off-by: Nicolas Lebedenco <nicolas.lebedenco@tasksistemas.com.br>

This line should go _after_ the Changelog entry...

> It fixes the output of the command usb storage. It was printing  
> "Device 0: not available" because the IF_TYPE_USB was not included into the 
> switch statement.

and before the actual patch (namely here!)

> --- u-boot-1.3.4.original/disk/part.c	2008-08-12 11:08:38.000000000 -0300
> +++ u-boot-1.3.4/disk/part.c	2008-09-04 14:48:55.000000000 -0300
> @@ -124,6 +124,12 @@ void dev_print (block_dev_desc_t *dev_de
>  			dev_desc->revision,
>  			dev_desc->product);
>  		break;
> +	case IF_TYPE_USB:
> +		printf ("Vendor: %s Rev: %s Prod: %s\n",
> +			dev_desc->vendor,
> +			dev_desc->revision,
> +			dev_desc->product);
> +		break;
>  	case IF_TYPE_UNKNOWN:
>  	default:
>  		puts ("not available\n");

Sorry for beeing so pedantic, but could you fix this and resend once
more without context?  This is so we can use git-am to apply your
patch!

Obrigado!

Markus

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de")

[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

[Wolfgang Denk]

Dear Markus =?iso-8859-1?Q?Klotzb=FCcher?=,

In message <20080909135037.GA5659@lisa> you wrote:
> 
> Sorry for beeing so pedantic, but could you fix this and resend once
> more without context?  This is so we can use git-am to apply your
> patch!

You are right, but I'm in a generous mode today. I will clean this up.

No need to repost.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Making files is easy under  the  UNIX  operating  system.  Therefore,
users  tend  to  create  numerous  files  using large amounts of file
space. It has been said that the only standard thing about  all  UNIX
systems  is  the  message-of-the-day  telling users to clean up their
files.                            -- System V.2 administrator's guide

[U-Boot] Fix dev_print for when it is called from usb_stor_info (usb storage command)

[Wolfgang Denk]

Dear =?iso-8859-1?q?N=EDcolas_Carneiro_Lebedenco?=,

In message <200809091013.47319.nicolas.lebedenco@tasksistemas.com.br> you wrote:
>
> Here it goes. I'm not sure if I got you right. Is it ok, now ?

As Markus mentioned, there were still a few formal issues. I cleaned
these up for you. 

> It fixes the output of the command usb storage. It was printing
> "Device 0: not available" because the IF_TYPE_USB was not included into the
> switch statement.
> 
> --- u-boot-1.3.4.original/disk/part.c	2008-08-12 11:08:38.000000000 -0300
> +++ u-boot-1.3.4/disk/part.c	2008-09-04 14:48:55.000000000 -0300

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Pull the wool over your own eyes!"                - J.R. "Bob" Dobbs