From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [patch 1/1] Make usb-stop() safe to call multiple times in a row.
Date: Tue, 9 Sep 2008 16:35:00 +0200 [thread overview]
Message-ID: <20080909143500.GA11987@lisa> (raw)
In-Reply-To: <20080820092551.478336687@bohmer.net>
On Wed, Aug 20, 2008 at 11:22:02AM +0200, Remy Bohmer wrote:
> A recent commit (936897d4d1365452bbbdf8430db5e7769ef08d38)
> enabled the usb_stop() command in common/cmd_bootm.c which was
> not enabled for some time, because no board did actually set the
> CFG_CMD_USB flag. So, now the usb_stop() is executed before
> loading the linux kernel.
>
> However, the usb_ohci driver hangs up (at least on AT91SAM) if the
> driver is stopped twice (e.g. the peripheral clock is stopped on AT91).
> If some other piece of code calls usb_stop() before the bootm command,
> this command will hangup the system during boot.
> (usb start and stop is typically used while booting from usb memory stick)
>
> But, stopping the usb stack twice is useless anyway, and a flag already
> existed that kept track on the usb_init()/usb_stop() calls.
> So, we now check if the usb stack is really started before we stop it.
>
> This problem is now fixed in both the upper as low-level layer.
>
> Signed-off-by: Remy Bohmer <linux@bohmer.net>
Acked-by: Markus Klotzbuecher <mk@denx.de>
Wolfgang, please apply!
Best regards
Markus
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de")
next prev parent reply other threads:[~2008-09-09 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 9:22 [U-Boot] [patch 0/1] fix hangup during boot when USB is used Remy Bohmer
2008-08-20 9:22 ` [U-Boot] [patch 1/1] Make usb-stop() safe to call multiple times in a row Remy Bohmer
2008-09-09 14:35 ` Markus Klotzbücher [this message]
2008-09-09 15:00 ` Wolfgang Denk
2008-09-09 14:59 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909143500.GA11987@lisa \
--to=mk@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox