From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Tue, 09 Sep 2008 23:07:47 +0200
Subject: [U-Boot] [PATCH v2] ARM: Use do_div() instead of division for
	"long long".
In-Reply-To: <Pine.LNX.4.64.0809092249070.9737@axis700.grange>
References: <1220914771-14645-1-git-send-email-wd@denx.de>
	<1220918912-15691-1-git-send-email-wd@denx.de>
	<Pine.LNX.4.64.0809092249070.9737@axis700.grange>
Message-ID: <20080909210747.854B02491D@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Guennadi Liakhovetski,

In message <Pine.LNX.4.64.0809092249070.9737@axis700.grange> you wrote:
> 
> > +	do_div(val, (data[i][0] - data[i-1][0]));
> 
> Looking at how do_div() is defined, and it handles its parameters 
> carefully, one shouldn't need the extra parenthesis here, i.e.,

The are not exactly need (and actually a remainder from  the  copy  &
paste of the old code), but on the other hand they don't hurt either,
and they make the argument's easier to parse, at least to my eyes.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Felson's Law:
	To steal ideas from one person is plagiarism; to steal from
	many is research.