* [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR
@ 2008-09-09 22:13 Victor Gallardo
2008-09-10 2:50 ` Stefan Roese
2008-09-10 9:09 ` Wolfgang Denk
0 siblings, 2 replies; 5+ messages in thread
From: Victor Gallardo @ 2008-09-09 22:13 UTC (permalink / raw)
To: u-boot
On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and glacier.
Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
---
v2:
- Add description for CFG_I2C_DTT_ADDR to README
README | 6 ++++++
drivers/hwmon/lm75.c | 4 ++++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/README b/README
index 37449d1..75d9329 100644
--- a/README
+++ b/README
@@ -1392,6 +1392,12 @@ The following options need to be configured:
If defined, then this indicates the I2C bus number for the DTT.
If not defined, then U-Boot assumes that DTT is on I2C bus 0.
+ CFG_I2C_DTT_ADDR:
+
+ If defined, specifies the I2C address of the DTT device.
+ If not defined, then U-Boot uses predefined value for
+ specified DTT device.
+
CONFIG_FSL_I2C
Define this option if you want to use Freescale's I2C driver in
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index 8051cb2..67a18f6 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -38,7 +38,11 @@
/*
* Device code
*/
+#if defined(CFG_I2C_DTT_ADDR)
+#define DTT_I2C_DEV_CODE CFG_I2C_DTT_ADDR
+#else
#define DTT_I2C_DEV_CODE 0x48 /* ON Semi's LM75 device */
+#endif
#define DTT_READ_TEMP 0x0
#define DTT_CONFIG 0x1
#define DTT_TEMP_HYST 0x2
--
1.5.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR
2008-09-09 22:13 [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR Victor Gallardo
@ 2008-09-10 2:50 ` Stefan Roese
2008-09-10 14:50 ` Victor Gallardo
2008-09-10 9:09 ` Wolfgang Denk
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Roese @ 2008-09-10 2:50 UTC (permalink / raw)
To: u-boot
Victor,
On Wednesday 10 September 2008, Victor Gallardo wrote:
> On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and
> glacier.
This patch is not really ppc4xx related, so please replace the "ppc4xx:" from
the subject line with "DTT:".
Other than this:
Acked-by: Stefan Roese <sr@denx.de>
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR
2008-09-09 22:13 [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR Victor Gallardo
2008-09-10 2:50 ` Stefan Roese
@ 2008-09-10 9:09 ` Wolfgang Denk
1 sibling, 0 replies; 5+ messages in thread
From: Wolfgang Denk @ 2008-09-10 9:09 UTC (permalink / raw)
To: u-boot
Dear Victor Gallardo,
In message <1220998409-26390-1-git-send-email-vgallardo@amcc.com> you wrote:
> On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and glacier.
>
> Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
> ---
> v2:
> - Add description for CFG_I2C_DTT_ADDR to README
>
> README | 6 ++++++
> drivers/hwmon/lm75.c | 4 ++++
> 2 files changed, 10 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The bad reputation UNIX has gotten is totally undeserved, laid on by
people who don't understand, who have not gotten in there and tried
anything." -- Jim Joyce, owner of Jim Joyce's UNIX Bookstore
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR
2008-09-10 2:50 ` Stefan Roese
@ 2008-09-10 14:50 ` Victor Gallardo
2008-09-10 15:09 ` Stefan Roese
0 siblings, 1 reply; 5+ messages in thread
From: Victor Gallardo @ 2008-09-10 14:50 UTC (permalink / raw)
To: u-boot
Hello Stefan,
>On Wednesday 10 September 2008, Victor Gallardo wrote:
>> On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and
>> glacier.
>
>This patch is not really ppc4xx related, so please replace the "ppc4xx:" from
>the subject line with "DTT:".
>
>Other than this:
>
>Acked-by: Stefan Roese sr at denx.de
You are correct. I should have used DTT instead. Sorry about that.
Wolfgang has accepted in his tree. Do I still need to resubmit to get it in your tree?
Thanks,
Victor Gallardo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR
2008-09-10 14:50 ` Victor Gallardo
@ 2008-09-10 15:09 ` Stefan Roese
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Roese @ 2008-09-10 15:09 UTC (permalink / raw)
To: u-boot
On Wednesday 10 September 2008, Victor Gallardo wrote:
> >> On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and
> >> glacier.
> >
> >This patch is not really ppc4xx related, so please replace the "ppc4xx:"
> > from the subject line with "DTT:".
> >
> >Other than this:
> >
> >Acked-by: Stefan Roese sr at denx.de
>
> You are correct. I should have used DTT instead. Sorry about that.
No problem.
> Wolfgang has accepted in his tree. Do I still need to resubmit to get it in
> your tree?
No, its ok. But please use the correct subject next time.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-09-10 15:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-09 22:13 [U-Boot] [PATCH v2] ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR Victor Gallardo
2008-09-10 2:50 ` Stefan Roese
2008-09-10 14:50 ` Victor Gallardo
2008-09-10 15:09 ` Stefan Roese
2008-09-10 9:09 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox