From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] i.MX31: switch to CFG_HZ=1000
Date: Tue, 16 Sep 2008 12:39:30 +0200 [thread overview]
Message-ID: <20080916103930.3D4FC2487F@gemini.denx.de> (raw)
In-Reply-To: <1221553118-15819-3-git-send-email-plagnioj@jcrosoft.com>
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message <1221553118-15819-3-git-send-email-plagnioj@jcrosoft.com> you wrote:
> From: Guennadi Liakhovetski <lg@denx.de>
>
> Switch to the standard CFG_HZ=1000 value, while at it, minor white-space
> cleanup, remove CFG_CLKS_IN_HZ from config-headers. Tested on mx31ads,
> provides 2% or 0.4% precision depending on the
> CONFIG_MX31_TIMER_HIGH_PRECISION flag. Measured with stop-watch on 100s
> boot-delay.
>
> Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
Why are you reposting this?
And, even worse, why are you reposting a patch which you here
attribute to Guennady (without adding your own Signed-off-by line),
but this is actually not the original patch as submitted by Guennadi
but a modified version where you meddled with whitespaces (corrupting
Guennadi's nice alignment of the comments)? I see that you also
cleaned up some coding style violations (like trailing white space),
but not all of them (like '^ \t' pattern). And you added comments.
You must not modify other people's patches without recording the fact
that you did so. If you change their code, you have to record this
fact at least by adding your own Signed-off-by: line to the patch.
Please clean this up before resending a pull request.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All men should freely use those seven words which have the power to
make any marriage run smoothly: You know dear, you may be right.
next prev parent reply other threads:[~2008-09-16 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 8:18 [U-Boot] [PATCH 0/2] Revert "ARM: set GD_FLG_RELOC for boards skipping relocation to RAM" Jean-Christophe PLAGNIOL-VILLARD
2008-09-16 8:18 ` [U-Boot] [PATCH 1/2] ARM: set GD_FLG_RELOC at board init Jean-Christophe PLAGNIOL-VILLARD
2008-09-16 8:18 ` [U-Boot] [PATCH 2/2] i.MX31: switch to CFG_HZ=1000 Jean-Christophe PLAGNIOL-VILLARD
2008-09-16 10:39 ` Wolfgang Denk [this message]
2008-09-16 10:27 ` [U-Boot] [PATCH 1/2] ARM: set GD_FLG_RELOC at board init Wolfgang Denk
2008-09-16 10:26 ` [U-Boot] [PATCH 0/2] Revert "ARM: set GD_FLG_RELOC for boards skipping relocation to RAM" Wolfgang Denk
2008-09-16 10:30 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916103930.3D4FC2487F@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox